Skip to content

Commit 0e67485

Browse files
Revert "Add CUDA Graph support for the CUDA plugin EP (#28002)"
This reverts commit 58a87dc.
1 parent 87b0643 commit 0e67485

24 files changed

Lines changed: 223 additions & 1365 deletions

docs/cuda_plugin_ep/QUICK_START.md

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ build.bat --cmake_generator "Visual Studio 17 2022" --config Release --build_whe
1212
--cudnn_home "D:\path\to\cudnn-installation-root" ^
1313
--use_vcpkg --use_binskim_compliant_compile_flags ^
1414
--cmake_extra_defines "CMAKE_CUDA_ARCHITECTURES=native" ^
15+
--cmake_extra_defines "onnxruntime_BUILD_UNIT_TESTS=ON" ^
1516
--cmake_extra_defines "onnxruntime_BUILD_CUDA_EP_AS_PLUGIN=ON"
1617
```
1718

@@ -105,7 +106,7 @@ The focused validation script for the CUDA Plugin EP is `onnxruntime/test/python
105106

106107
### Test prerequisites
107108

108-
- Build ONNX Runtime with `onnxruntime_BUILD_CUDA_EP_AS_PLUGIN=ON`.
109+
- Build ONNX Runtime with `onnxruntime_BUILD_CUDA_EP_AS_PLUGIN=ON` and `onnxruntime_BUILD_UNIT_TESTS=ON`.
109110
- Install the built ONNX Runtime wheel.
110111
- Install Python test dependencies. `test_cuda_plugin_ep.py` uses PyTorch for CPU-side reference computations, so CPU-only PyTorch is sufficient.
111112

@@ -150,10 +151,16 @@ python test_cuda_plugin_ep.py
150151

151152
The script validates plugin registration, device enumeration, provider options, operator coverage, and that key nodes are actually assigned to `CudaPluginExecutionProvider`.
152153

154+
## Known Limitations
155+
* The plugin does not currently support CUDA Graphs.
156+
* The plugin direct-allocates memory using `cudaMalloc` resulting in a potential performance penalty compared to the integrated Memory Arena.
153157

154158
## Verification
155159
You can generate a parity report comparing the kernels available in the plugin EP versus the statically linked CUDA EP.
156160
```bash
161+
# Check static source registration parity:
162+
python tools/ci_build/cuda_plugin_parity_report.py
163+
157164
# Check runtime registry parity:
158165
python tools/ci_build/cuda_plugin_parity_report.py --runtime --plugin-ep-lib build/Linux/RelWithDebInfo/libonnxruntime_providers_cuda_plugin.so
159166
```

docs/cuda_plugin_ep/cuda_graph_for_cuda_plugin.md

Lines changed: 0 additions & 134 deletions
This file was deleted.

0 commit comments

Comments
 (0)