Commit 84d9370
committed
Address review feedback on batched right-padded rotary prefill test
- Reword the tolerance-justification comment to name the actual failure
modes per EP (CPU: uninitialized attention-probs reads; WebGPU: u32
underflow on rotary past_seqlen, see PR #29002) instead of calling it
an "underflow bug" generically.
- Add an explicit std::isfinite check over the full batched output so the
regression is caught deterministically regardless of whether the
allocator returns zeroed pages.1 parent c4a3254 commit 84d9370
1 file changed
Lines changed: 15 additions & 3 deletions
Lines changed: 15 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2567 | 2567 | | |
2568 | 2568 | | |
2569 | 2569 | | |
| 2570 | + | |
| 2571 | + | |
| 2572 | + | |
| 2573 | + | |
| 2574 | + | |
| 2575 | + | |
| 2576 | + | |
| 2577 | + | |
| 2578 | + | |
2570 | 2579 | | |
2571 | | - | |
2572 | | - | |
2573 | | - | |
| 2580 | + | |
| 2581 | + | |
| 2582 | + | |
| 2583 | + | |
| 2584 | + | |
| 2585 | + | |
2574 | 2586 | | |
2575 | 2587 | | |
2576 | 2588 | | |
| |||
0 commit comments