Commit af8b577
Fix --build_wasm_static_lib implicitly enable --build_wasm (#27342)
### Description
Moves the `--build_wasm_static_lib → --build_wasm` implication from
`build.py` into `build_args.py`'s post-processing, **before** the cmake
generator selection. Previously, `build_args.py` chose the generator
based on `args.build_wasm` (still `False`), and `build.py` only set it
to `True` afterwards—too late.
- **`tools/ci_build/build_args.py`**: Set `args.build_wasm = True` when
`args.build_wasm_static_lib` is set, prior to generator and
cross-compilation logic.
- **`tools/ci_build/build.py`**: Remove the now-redundant identical
check.
### Motivation and Context
Using `--build_wasm_static_lib` without `--build_wasm` caused cmake to
use the wrong generator (e.g., Visual Studio instead of Ninja on
Windows) and miss Emscripten-specific configuration, leading to build
failures like missing `libiconv`.
<!-- START COPILOT CODING AGENT TIPS -->
---
💬 We'd love your input! Share your thoughts on Copilot coding agent in
our [2 minute survey](https://gh.io/copilot-coding-agent-survey).
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: fs-eire <7679871+fs-eire@users.noreply.github.com>1 parent 9b24046 commit af8b577
2 files changed
Lines changed: 4 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2327 | 2327 | | |
2328 | 2328 | | |
2329 | 2329 | | |
2330 | | - | |
2331 | | - | |
2332 | | - | |
2333 | 2330 | | |
2334 | 2331 | | |
2335 | 2332 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
938 | 938 | | |
939 | 939 | | |
940 | 940 | | |
| 941 | + | |
| 942 | + | |
| 943 | + | |
| 944 | + | |
941 | 945 | | |
942 | 946 | | |
943 | 947 | | |
| |||
0 commit comments