Describe the issue
The current logic in ORT Expo config plugin hardcodes the path to the pod injected to the app's Podfile during CNG: newSrc: " pod 'onnxruntime-react-native', :path => '../node_modules/onnxruntime-react-native'",. In practice, this does not work in monorepositories with package managers supporting hosting (e.g. pnpm), where the package may be installed elsewhere.
As an example, consider the following monorepository layout:
- package.json
- node_modules <- onnxruntime-react-native hoisted install location
- apps/
- myapp/
- package.json <- onnxruntime-react-native dependency
- ios
- Podfile <- reference to the onnxruntime-react-native should be: ../../../node_modules/onnxruntime-react-native
To reproduce
- Create a monorepository with pnpm
mkdir apps/ && cd apps/
- Create an expo app:
pnpm create expo-app
pnpm add onnxruntime-react-native
- Add the onnxruntime-react-native Expo config plugin to
app.json
npx expo prebuild
- Observe wrong path in the synthesized
ios/Podfile - it will cause an error when installing pods
Urgency
Incompatibility with monorepositories when using Expo
Platform
iOS
OS Version
N/A
ONNX Runtime Installation
Released Package
Compiler Version (if 'Built from Source')
No response
Package Name (if 'Released Package')
None
ONNX Runtime Version or Commit ID
1.24.3
ONNX Runtime API
Objective-C/Swift
Architecture
Other / Unknown
Execution Provider
Other / Unknown
Execution Provider Library Version
No response
Describe the issue
The current logic in ORT Expo config plugin hardcodes the path to the pod injected to the app's
Podfileduring CNG:newSrc: " pod 'onnxruntime-react-native', :path => '../node_modules/onnxruntime-react-native'",. In practice, this does not work in monorepositories with package managers supporting hosting (e.g. pnpm), where the package may be installed elsewhere.As an example, consider the following monorepository layout:
To reproduce
mkdir apps/ && cd apps/pnpm create expo-apppnpm add onnxruntime-react-nativeapp.jsonnpx expo prebuildios/Podfile- it will cause an error when installing podsUrgency
Incompatibility with monorepositories when using Expo
Platform
iOS
OS Version
N/A
ONNX Runtime Installation
Released Package
Compiler Version (if 'Built from Source')
No response
Package Name (if 'Released Package')
None
ONNX Runtime Version or Commit ID
1.24.3
ONNX Runtime API
Objective-C/Swift
Architecture
Other / Unknown
Execution Provider
Other / Unknown
Execution Provider Library Version
No response