Fix build error on vsinpu provider#27984
Open
HungMingWu wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a VSINPU provider build failure by ensuring the provider target can include the generated onnxruntime_config.h header, which is emitted into the CMake binary directory during configure.
Changes:
- Add
${CMAKE_CURRENT_BINARY_DIR}to the include directories foronnxruntime_providers_vsinpuso#include "onnxruntime_config.h"resolves during compilation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
I think the regression is not related to the MR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two places to need fix.
onnxruntime_config.h, but it exists at ${CMAKE_CURRENT_BINARY_DIR} directory, other providers, like openvino, qnn have been include ${CMAKE_CURRENT_BINARY_DIR}