Skip to content

fix: support monorepositories in ORT RN Expo config plugin #28673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
artus9033 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: support monorepositories in ORT RN Expo config plugin #28673

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion js/react_native/app.plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,17 @@ const pkg = require('onnxruntime-react-native/package.json');
const path = require('path');
const fs = require('fs');

/**
* Converts directory path to node_modules to a relative path for the ios/Podfile file.
* @param {string} iosProjectRoot the ios/ directory path
* @param {string} packageRoot the node_modules/onnxruntime-react-native directory path
* @returns {string} the relative path to the packageRoot from the iosProjectRoot
*/
function toPodfileRelativePath(iosProjectRoot, packageRoot) {
const rel = path.relative(iosProjectRoot, packageRoot);
return rel ? rel.split(path.sep).join('/') : '.';
}

const withOrt = (config) => {
// Add build dependency to gradle file
config = configPlugin.withAppBuildGradle(config, (config) => {
Expand Down Expand Up @@ -79,9 +90,15 @@ const withOrt = (config) => {
(config) => {
const podFilePath = path.join(config.modRequest.platformProjectRoot, 'Podfile');
const contents = fs.readFileSync(podFilePath, { encoding: 'utf-8' });
const packageRoot = path.dirname(
require.resolve(`${pkg.name}/package.json`, {
paths: [config.modRequest.projectRoot],
})
);
const podPath = toPodfileRelativePath(config.modRequest.platformProjectRoot, packageRoot);
const updatedContents = generateCode.mergeContents({
src: contents,
newSrc: " pod 'onnxruntime-react-native', :path => '../node_modules/onnxruntime-react-native'",
newSrc: ` pod 'onnxruntime-react-native', :path => '${podPath}'`,
tag: 'onnxruntime-react-native',
anchor: /^target.+do$/,
offset: 1,
Expand Down