Fix GCC 15 -Werror build warnings#29679
Open
mirounga wants to merge 1 commit into
Open
Conversation
GCC 15 with -march=native emits several false-positive warnings that fail the -Werror build. Fixed the underlying code so the warnings no longer fire, with no functional change: - skip_layer_norm_fusion.cc: make the FindPath matcher paths function-local `static const std::vector` (they are compile-time constants). Built once instead of per node iteration, and the destructors run at exit rather than inlined into ApplyImpl, sidestepping a -Wfree-nonheap-object false positive. - test/unittest_util/conversion.h: convert the float<->half / int cast helpers from Eigen Map cast-assignments to std::transform. The Eigen path vectorizes to _mm512_loadu_ps, which GCC 15 mis-flags with -Warray-bounds when inlined into callers passing small fixed-size buffers. Semantics are unchanged. - zipmap_test.cc: take std::initializer_list<T> and materialize the class-list vector inside TestHelper, keeping the vector out of the inlined TEST body where GCC 15 emits a -Wfree-nonheap-object false positive.
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
static const std::vector(they are compile-time constants). Built once instead of per node iteration, and the destructors run at exit rather than inlined into ApplyImpl, sidestepping a -Wfree-nonheap-object false positive.Motivation and Context
GCC 15 with -march=native emits several false-positive warnings that fail the -Werror build. Fixed the underlying code so the warnings no longer fire, with no functional change: