[IR] Support specifying output value in Tape#2225
Merged
justinchuby merged 6 commits intomainfrom Apr 29, 2025
Merged
Conversation
When a user wants to specify names for output values, they can initialize the value first then supply them to tape op() call.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for specifying output values in Tape operations by allowing users to initialize and supply output values explicitly.
- Added an optional output parameter to op() to allow a single output value specification.
- Extended op_multi_output() with optional outputs in addition to num_outputs, with validation to ensure at least one is provided.
❌ 17 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
xadupre
reviewed
Apr 25, 2025
gramalingam
approved these changes
Apr 28, 2025
Collaborator
Author
Will create as a follow up, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user wants to specify names for output values, they can initialize the value first then supply them to tape op() call.
Also renamed symbolic_multi_output to symblic_multi_out to match https://pytorch.org/docs/main/onnx_ops.html#torch.onnx.ops.symbolic_multi_out