Conversation
The ONNX 1.18 release also updated schema which I think preserves attribute order. So the rest of the files changed too.
❌ 4 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
| def Pad( | ||
| self, | ||
| data: T_Pad, | ||
| pads: INT64, | ||
| constant_value: Optional[T_Pad] = None, | ||
| axes: Optional[Tind_Pad] = None, | ||
| *, | ||
| mode: str = "constant", | ||
| ) -> T_Pad: |
Check warning
Code scanning / CodeQL
Signature mismatch in overriding method Warning
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 1 year ago
To fix the issue, the Pad method in the Opset23 class must be updated to match the signature of the Pad method in the Opset22 class. This involves ensuring that the parameters, their types, and default values are consistent with the overridden method. If the Opset22 class's Pad method has additional parameters or different parameter types, these must be incorporated into the Opset23 method.
Steps:
- Identify the exact signature of the
Padmethod in theOpset22class. - Update the
Padmethod in theOpset23class to match the signature of theOpset22method. - Ensure that the implementation of the
Padmethod inOpset23still adheres to the ONNX operator specification for version 23.
| @@ -1184,2 +1184,3 @@ | ||
| mode: str = "constant", | ||
| extra_param: Optional[str] = None, # Example of a parameter from Opset22 | ||
| ) -> T_Pad: |
| UINT8, | ||
| ) | ||
|
|
||
| def Reshape(self, data: T_Reshape, shape: INT64, *, allowzero: int = 0) -> T_Reshape: |
Check warning
Code scanning / CodeQL
Signature mismatch in overriding method Warning
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 1 year ago
To fix the issue, the Reshape method in the Opset23 class must be updated to match the signature of the Reshape method in the Opset22 class. This involves ensuring that the Reshape method in Opset23 accepts all the parameters that the Reshape method in Opset22 does. If the parent class's method has additional parameters, they should be added to the overriding method in Opset23. The functionality of the Reshape method in Opset23 should remain consistent with its intended behavior.
| @@ -1544,3 +1544,3 @@ | ||
|
|
||
| def Reshape(self, data: T_Reshape, shape: INT64, *, allowzero: int = 0) -> T_Reshape: | ||
| def Reshape(self, data: T_Reshape, shape: INT64, *, allowzero: int = 0, **kwargs) -> T_Reshape: | ||
| r"""[🌐 Reshape(23)](https://onnx.ai/onnx/operators/onnx__Reshape.html#reshape-23 "Online Documentation") |
| UINT8, | ||
| ) | ||
|
|
||
| def Unsqueeze(self, data: T_Unsqueeze, axes: INT64) -> T_Unsqueeze: |
Check warning
Code scanning / CodeQL
Signature mismatch in overriding method Warning
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 1 year ago
To fix the issue, the Unsqueeze method in the Opset23 class must be updated to match the signature of the Unsqueeze method in the Opset22 class. This involves:
- Identifying the exact signature of the
Unsqueezemethod inOpset22. - Modifying the
Unsqueezemethod inOpset23to ensure it accepts the same parameters and has the same return type as the method inOpset22.
The fix should preserve the functionality of the Unsqueeze method in Opset23 while ensuring compatibility with the parent class.
| @@ -2214,3 +2214,3 @@ | ||
|
|
||
| def Unsqueeze(self, data: T_Unsqueeze, axes: INT64) -> T_Unsqueeze: | ||
| def Unsqueeze(self, data: T_Unsqueeze, axes: Union[INT64, Sequence[INT64]]) -> T_Unsqueeze: | ||
| r"""[🌐 Unsqueeze(23)](https://onnx.ai/onnx/operators/onnx__Unsqueeze.html#unsqueeze-23 "Online Documentation") |
Add opset23 support.