Merged
Conversation
❌ 5 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the documentation for the IR submodules and related API components by adding detailed pages for traversal, tape, passes, external data, convenience functions, core IR constructs, and model transformation utilities.
- Added new documentation pages for ir.traversal, ir.tape, ir.passes_common, ir.passes, ir.external_data, ir.convenience, and core IR functions and classes.
- Updated the documentation structure by revising index pages for IR APIs and the overall docs, and added new API pages for version_converter, rewriter, and optimizer while removing the obsolete tools page.
Reviewed Changes
Copilot reviewed 24 out of 27 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| docs/ir/ir_api/ir_traversal.md | Added page for IR traversal API documentation |
| docs/ir/ir_api/ir_tape.md | Added page for IR tape API documentation |
| docs/ir/ir_api/ir_passes_common.md | Added page for common IR passes and utilities |
| docs/ir/ir_api/ir_passes.md | Added page for IR passes including pass infrastructure |
| docs/ir/ir_api/ir_external_data.md | Added page for external data handling in IR |
| docs/ir/ir_api/ir_convenience.md | Added page for IR convenience helper functions |
| docs/ir/ir_api/index.md | Updated index for IR API documentation |
| docs/ir/core.md | Updated the core IR documentation splitting functions and classes |
| docs/ir/index.md | Revised IR index to use new IR API structure |
| docs/index.md | Updated main docs index to reference new IR documentation |
| docs/api/version_converter.md | Added documentation for version converter API |
| docs/api/tools.md | Removed obsolete tools documentation page |
| docs/api/rewriter.md | Added documentation for rewriter API |
| docs/api/optimizer.md | Added documentation for optimizer API |
| docs/api/index.md | Updated API index to reflect reorganized sections |
Files not reviewed (3)
- docs/_templates/classtemplate.rst: Language not supported
- docs/_templates/classtemplate_inherited.rst: Language not supported
- docs/_templates/functiontemplate.rst: Language not supported
Comments suppressed due to low confidence (2)
docs/ir/ir_api/ir_external_data.md:20
- [nitpick] Consider adding concrete usage examples for the onnxscript.external_data functions to further improve the clarity and usefulness of the documentation.
<!-- TODO: Create examples -->
docs/api/tools.md:1
- Verify that the removal of the docs/api/tools.md file does not break any navigation links or references in the documentation index files.
# Tools
xadupre
approved these changes
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Major improvement in documenting all submodules in onnxscript.ir. Also added documentation for the rewriter, optimizer and version converter.