Skip to content

Add back inliner to version converter#2813

Merged
titaiwangms merged 1 commit intomicrosoft:mainfrom
titaiwangms:titaiwang/add_back_inliner_to_vc
Feb 18, 2026
Merged

Add back inliner to version converter#2813
titaiwangms merged 1 commit intomicrosoft:mainfrom
titaiwangms:titaiwang/add_back_inliner_to_vc

Conversation

@titaiwangms
Copy link
Copy Markdown
Contributor

@titaiwangms titaiwangms commented Feb 17, 2026

Basically, version converter only supports inlined model. In terms of torch onnx exporter, we should just remind/warn users that if their models includes local-function. We just don't support it.

series of version converter PRs:
#2791 (Removed assertion of no local function included)
#2799 (Missing opset import)
#2806 (Raise for RefAttr)

Maybe we should just try revert #2791?

cc @gramalingam @justinchuby

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.40%. Comparing base (e6f79e1) to head (bb3c583).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2813      +/-   ##
==========================================
- Coverage   70.52%   70.40%   -0.12%     
==========================================
  Files         228      228              
  Lines       27135    27140       +5     
  Branches     2727     2727              
==========================================
- Hits        19137    19108      -29     
- Misses       7065     7096      +31     
- Partials      933      936       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinchuby
Copy link
Copy Markdown
Collaborator

justinchuby commented Feb 18, 2026

What’s missing? Any new errors?

@titaiwangms
Copy link
Copy Markdown
Contributor Author

titaiwangms commented Feb 18, 2026

What’s missing? Any new errors?

#2812 torchlib onnx function. 40/200 models fail on benchmark.

@titaiwangms
Copy link
Copy Markdown
Contributor Author

titaiwangms commented Feb 18, 2026

I will just revert the commits

@titaiwangms
Copy link
Copy Markdown
Contributor Author

titaiwangms commented Feb 18, 2026

#2815

@titaiwangms titaiwangms reopened this Feb 18, 2026
@titaiwangms titaiwangms enabled auto-merge (squash) February 18, 2026 21:26
@titaiwangms titaiwangms merged commit bfee593 into microsoft:main Feb 18, 2026
57 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants