Revert version converter support on local function#2815
Closed
titaiwangms wants to merge 3 commits intomicrosoft:mainfrom
Closed
Revert version converter support on local function#2815titaiwangms wants to merge 3 commits intomicrosoft:mainfrom
titaiwangms wants to merge 3 commits intomicrosoft:mainfrom
Conversation
…ttr (microsoft#2806)" This reverts commit d83d50b.
This reverts commit 5ae26d9.
)" This reverts commit 74a5f34.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2815 +/- ##
==========================================
- Coverage 70.52% 70.42% -0.10%
==========================================
Files 228 228
Lines 27135 27077 -58
Branches 2727 2723 -4
==========================================
- Hits 19137 19070 -67
- Misses 7065 7071 +6
- Partials 933 936 +3 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
version converter does not support local function currently, and it needs inliner within the call. The PRs broke benchmakring and Olive.