Remove dead Opset function_defs registration#2901
Merged
gramalingam merged 1 commit intomainfrom Apr 23, 2026
Merged
Conversation
The function_defs dict on Opset and add_function_def() method are written to but never read from anywhere in the codebase. Removing this dead code eliminates a memory leak where the singleton Opset holds references to all compiled functions forever. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2901 +/- ##
==========================================
- Coverage 72.51% 72.48% -0.04%
==========================================
Files 250 258 +8
Lines 30955 31471 +516
Branches 2960 2973 +13
==========================================
+ Hits 22448 22811 +363
- Misses 7504 7650 +146
- Partials 1003 1010 +7 ☔ View full report in Codecov by Sentry. |
justinchuby
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function_defs dict on Opset and add_function_def() method are written to but never read from anywhere in the codebase. Removing this dead code eliminates a memory leak where the singleton Opset holds references to all compiled functions forever.
This will also help simplify further cleanups (relating to better handling of conversion of script functions to IR ... which currently goes from IR to proto to IR unnecessarily).