Skip to content

Remove dead Opset function_defs registration#2901

Merged
gramalingam merged 1 commit intomainfrom
rama/drop-fun-register
Apr 23, 2026
Merged

Remove dead Opset function_defs registration#2901
gramalingam merged 1 commit intomainfrom
rama/drop-fun-register

Conversation

@gramalingam
Copy link
Copy Markdown
Collaborator

@gramalingam gramalingam commented Apr 23, 2026

The function_defs dict on Opset and add_function_def() method are written to but never read from anywhere in the codebase. Removing this dead code eliminates a memory leak where the singleton Opset holds references to all compiled functions forever.

This will also help simplify further cleanups (relating to better handling of conversion of script functions to IR ... which currently goes from IR to proto to IR unnecessarily).

The function_defs dict on Opset and add_function_def() method are written
to but never read from anywhere in the codebase. Removing this dead code
eliminates a memory leak where the singleton Opset holds references to
all compiled functions forever.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.48%. Comparing base (1911741) to head (250686d).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2901      +/-   ##
==========================================
- Coverage   72.51%   72.48%   -0.04%     
==========================================
  Files         250      258       +8     
  Lines       30955    31471     +516     
  Branches     2960     2973      +13     
==========================================
+ Hits        22448    22811     +363     
- Misses       7504     7650     +146     
- Partials     1003     1010       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gramalingam gramalingam merged commit ceac545 into main Apr 23, 2026
29 of 33 checks passed
@gramalingam gramalingam deleted the rama/drop-fun-register branch April 23, 2026 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants