Skip to content

Commit 76b6938

Browse files
Copilotbrianrob
andauthored
Fix NVDA screen reader incorrect list count for File menu separators (#2257)
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: brianrob <6210322+brianrob@users.noreply.github.com> Co-authored-by: Brian Robbins <brianrob@microsoft.com>
1 parent 415381c commit 76b6938

2 files changed

Lines changed: 0 additions & 21 deletions

File tree

src/PerfView/MainWindow.xaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@
2929
<CommandBinding Command="{x:Static src:MainWindow.MergeCommand}" Executed="DoMerge"/>
3030
<CommandBinding Command="{x:Static src:MainWindow.ZipCommand}" Executed="DoZip"/>
3131
<CommandBinding Command="{x:Static src:MainWindow.UnZipCommand}" Executed="DoUnZip"/>
32-
<CommandBinding Command="{x:Static src:MainWindow.HideCommand}" Executed="DoHide" CanExecute="CanHide" />
3332
<CommandBinding Command="{x:Static src:MainWindow.UserCommand}" Executed="DoUserCommand"/>
3433
<CommandBinding Command="{x:Static src:MainWindow.RefreshDirCommand}" Executed="DoRefreshDir"/>
3534
<CommandBinding Command="{x:Static src:MainWindow.OpenCommand}" Executed="DoOpen"/>
@@ -79,9 +78,6 @@
7978
<MenuItem Header="Set Symbol _Path" Click="DoSetSymbolPath" ToolTip="Sets the locations to look for symbolic information (PDB files)."/>
8079
<MenuItem Header="_User Command" Command="{x:Static src:MainWindow.UserCommand}" ToolTip="Run a User Defined Command."/>
8180
<MenuItem Header="Go to Directory" Command="{x:Static src:MainWindow.FocusDirectoryCommand}" ToolTip="Focus and select the directory textbox."/>
82-
<Separator/>
83-
<MenuItem Header="_Hide" Command="{x:Static src:MainWindow.HideCommand}" ToolTip="Hides the current window (can reopen using windows explorer)"/>
84-
<Separator/>
8581
<MenuItem Header="_Exit" Click="DoExit"/>
8682
</MenuItem>
8783
<MenuItem Header="_Collect">

src/PerfView/MainWindow.xaml.cs

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -538,21 +538,6 @@ private void DoUnZip(object sender, RoutedEventArgs e)
538538
});
539539
}
540540

541-
private void DoHide(object sender, RoutedEventArgs e)
542-
{
543-
// TODO need count of all active children
544-
if (StackWindow.StackWindows.Count > 0)
545-
{
546-
Visibility = Visibility.Hidden;
547-
}
548-
}
549-
550-
private void CanHide(object sender, CanExecuteRoutedEventArgs e)
551-
{
552-
// TODO need count of all active children
553-
e.CanExecute = StackWindow.StackWindows.Count > 0;
554-
}
555-
556541
private void DoUserCommand(object sender, RoutedEventArgs e)
557542
{
558543
if (m_UserDefineCommandDialog == null)
@@ -1081,8 +1066,6 @@ private void Window_Closed(object sender, EventArgs e)
10811066
public static RoutedUICommand UnZipCommand = new RoutedUICommand("UnZip", "UnZip", typeof(MainWindow));
10821067
public static RoutedUICommand ItemHelpCommand = new RoutedUICommand("Help on Item", "ItemHelp", typeof(MainWindow));
10831068
public static RoutedUICommand OpenInBrowserCommand = new RoutedUICommand("Open in Browser", "OpenInBrowser", typeof(MainWindow));
1084-
public static RoutedUICommand HideCommand = new RoutedUICommand("Hide", "Hide", typeof(MainWindow),
1085-
new InputGestureCollection() { new KeyGesture(Key.H, ModifierKeys.Alt) });
10861069
public static RoutedUICommand UserCommand = new RoutedUICommand("User Command", "UserCommand", typeof(MainWindow),
10871070
new InputGestureCollection() { new KeyGesture(Key.U, ModifierKeys.Alt) });
10881071
public static RoutedUICommand RefreshDirCommand = new RoutedUICommand("Refresh Dir", "RefreshDir",

0 commit comments

Comments
 (0)