Skip to content

Commit 82782b6

Browse files
authored
Merge branch 'main' into win-arm64-driver-bundle
2 parents 8a09694 + 92a4b6f commit 82782b6

8 files changed

Lines changed: 18 additions & 11 deletions

File tree

.github/workflows/code-style.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
build:
1313
runs-on: ubuntu-latest
1414
steps:
15-
- uses: actions/checkout@v5
15+
- uses: actions/checkout@v6
1616
- name: Setup .NET Core
1717
uses: actions/setup-dotnet@v5
1818
with:

.github/workflows/nuget-package-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
matrix:
1818
os: [windows-latest, ubuntu-latest, macos-latest]
1919
steps:
20-
- uses: actions/checkout@v5
20+
- uses: actions/checkout@v6
2121
- name: Setup .NET Core
2222
uses: actions/setup-dotnet@v5
2323
with:

.github/workflows/publish_docker.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@ jobs:
1515
contents: read # This is required for actions/checkout to succeed
1616
environment: Docker
1717
steps:
18-
- uses: actions/checkout@v5
18+
- uses: actions/checkout@v6
1919
- name: Azure login
20-
uses: azure/login@v2
20+
uses: azure/login@v3
2121
with:
2222
client-id: ${{ secrets.AZURE_DOCKER_CLIENT_ID }}
2323
tenant-id: ${{ secrets.AZURE_DOCKER_TENANT_ID }}
@@ -32,7 +32,7 @@ jobs:
3232
shell: bash
3333
run: ./build.sh --download-driver
3434
- name: Set up Docker QEMU for arm64 docker builds
35-
uses: docker/setup-qemu-action@v3
35+
uses: docker/setup-qemu-action@v4
3636
with:
3737
platforms: arm64
3838
- run: ./utils/docker/publish_docker.sh stable

.github/workflows/test_docker.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
flavor: [jammy, noble]
2727
runs-on: [ubuntu-24.04, ubuntu-24.04-arm]
2828
steps:
29-
- uses: actions/checkout@v5
29+
- uses: actions/checkout@v6
3030
- name: Setup .NET Core
3131
uses: actions/setup-dotnet@v5
3232
with:

.github/workflows/tests.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,7 @@ jobs:
2121
browser: [chromium, firefox, webkit]
2222
os: [windows-latest, windows-11-arm, ubuntu-latest, macos-15-large]
2323
steps:
24-
- uses: actions/checkout@v5
25-
24+
- uses: actions/checkout@v6
2625
- name: Setup .NET Core
2726
uses: actions/setup-dotnet@v5
2827
with:

.github/workflows/tests_harness.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,12 @@ jobs:
1616
runs-on: ubuntu-latest
1717
timeout-minutes: 45
1818
steps:
19-
- uses: actions/checkout@v5
19+
- uses: actions/checkout@v6
2020
- name: Setup .NET Core
2121
uses: actions/setup-dotnet@v5
2222
with:
2323
dotnet-version: 8.0.x
24-
- uses: actions/setup-node@v5
24+
- uses: actions/setup-node@v6
2525
with:
2626
node-version: 22
2727
- name: Install prerequisites and download drivers

.github/workflows/validate-nuget-packages.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
build:
1313
runs-on: ubuntu-latest
1414
steps:
15-
- uses: actions/checkout@v5
15+
- uses: actions/checkout@v6
1616
- name: Setup .NET Core
1717
uses: actions/setup-dotnet@v5
1818
with:

src/Playwright/Core/Browser.cs

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,14 @@ internal class Browser : ChannelOwner, IBrowser
4343
internal string? _tracesDir = null;
4444
internal BrowserType _browserType = null!;
4545
internal string? _closeReason;
46+
private readonly EventHandler<Exception> _onConnectionClose;
4647

4748
internal Browser(ChannelOwner parent, string guid, BrowserInitializer initializer) : base(parent, guid)
4849
{
4950
IsConnected = true;
5051
_initializer = initializer;
52+
_onConnectionClose = (_, _) => DidClose();
53+
_connection.Close += _onConnectionClose;
5154
}
5255

5356
public event EventHandler<IBrowser>? Disconnected;
@@ -286,6 +289,11 @@ private void DidCreateContext(BrowserContext context)
286289

287290
internal void DidClose()
288291
{
292+
if (!IsConnected)
293+
{
294+
return;
295+
}
296+
_connection.Close -= _onConnectionClose;
289297
IsConnected = false;
290298
Disconnected?.Invoke(this, this);
291299
_closedTcs.TrySetResult(true);

0 commit comments

Comments
 (0)