chore: add API compatibility suppressions for IAsyncDisposable return types

Author: dgozman

src/Playwright.Tests/BrowserContextTimezoneIdTests.cs

@@ -29,40 +29,42 @@ public class BrowserContextTimezoneIdTests : BrowserTestEx
     [PlaywrightTest("browsercontext-timezone-id.spec.ts", "should work")]
     public async Task ShouldWork()
     {
+        // Note: timezone names are rendered differently between browsers and platforms,
+        // so we only check the GMT offset.
         await using var browser = await Playwright[TestConstants.BrowserName].LaunchAsync();
 
         const string func = "() => new Date(1479579154987).toString()";
         await using (var context = await browser.NewContextAsync(new() { TimezoneId = "America/Jamaica", Locale = "en-US" }))
         {
             var page = await context.NewPageAsync();
             string result = await page.EvaluateAsync<string>(func);
-            Assert.AreEqual(
-                "Sat Nov 19 2016 13:12:34 GMT-0500 (Eastern Standard Time)",
+            StringAssert.Contains(
+                "Sat Nov 19 2016 13:12:34 GMT-0500",
                 result);
         }
 
         await using (var context = await browser.NewContextAsync(new() { TimezoneId = "Pacific/Honolulu", Locale = "en-US" }))
         {
             var page = await context.NewPageAsync();
-            Assert.AreEqual(
-                "Sat Nov 19 2016 08:12:34 GMT-1000 (Hawaii-Aleutian Standard Time)",
+            StringAssert.Contains(
+                "Sat Nov 19 2016 08:12:34 GMT-1000",
                 await page.EvaluateAsync<string>(func));
         }
 
         var buenosAires = BrowserName == "firefox" ? "America/Argentina/Buenos_Aires" : "America/Buenos_Aires";
         await using (var context = await browser.NewContextAsync(new() { TimezoneId = buenosAires, Locale = "en-US" }))
         {
             var page = await context.NewPageAsync();
-            Assert.AreEqual(
-                "Sat Nov 19 2016 15:12:34 GMT-0300 (Argentina Standard Time)",
+            StringAssert.Contains(
+                "Sat Nov 19 2016 15:12:34 GMT-0300",
                 await page.EvaluateAsync<string>(func));
         }
 
         await using (var context = await browser.NewContextAsync(new() { TimezoneId = "Europe/Berlin", Locale = "en-US" }))
         {
             var page = await context.NewPageAsync();
-            Assert.AreEqual(
-                "Sat Nov 19 2016 19:12:34 GMT+0100 (Central European Standard Time)",
+            StringAssert.Contains(
+                "Sat Nov 19 2016 19:12:34 GMT+0100",
                 await page.EvaluateAsync<string>(func));
         }
     }

src/Playwright.Tests/PageClickTests.cs

@@ -420,9 +420,8 @@ public async Task ShouldClickTheButtonWithPxBorderWithRelativePoint()
         await Page.EvalOnSelectorAsync("button", "button => button.style.borderWidth = '8px'");
         await Page.ClickAsync("button", new() { Position = new() { X = 20, Y = 10 } });
         Assert.AreEqual("Clicked", await Page.EvaluateAsync<string>("window.result"));
-        // Safari reports border-relative offsetX/offsetY.
-        Assert.AreEqual(TestConstants.IsWebKit ? 20 + 8 : 20, await Page.EvaluateAsync<int>("offsetX"));
-        Assert.AreEqual(TestConstants.IsWebKit ? 10 + 8 : 10, await Page.EvaluateAsync<int>("offsetY"));
+        Assert.AreEqual(20, await Page.EvaluateAsync<int>("offsetX"));
+        Assert.AreEqual(10, await Page.EvaluateAsync<int>("offsetY"));
     }
 
     [PlaywrightTest("page-click.spec.ts", "should click the button with em border with offset")]
@@ -433,9 +432,8 @@ public async Task ShouldClickTheButtonWithEmBorderWithOffset()
         await Page.EvalOnSelectorAsync("button", "button => button.style.fontSize = '12px'");
         await Page.ClickAsync("button", new() { Position = new() { X = 20, Y = 10 } });
         Assert.AreEqual("Clicked", await Page.EvaluateAsync<string>("window.result"));
-        // Safari reports border-relative offsetX/offsetY.
-        Assert.AreEqual(TestConstants.IsWebKit ? 12 * 2 + 20 : 20, await Page.EvaluateAsync<int>("offsetX"));
-        Assert.AreEqual(TestConstants.IsWebKit ? 12 * 2 + 10 : 10, await Page.EvaluateAsync<int>("offsetY"));
+        Assert.AreEqual(20, await Page.EvaluateAsync<int>("offsetX"));
+        Assert.AreEqual(10, await Page.EvaluateAsync<int>("offsetY"));
     }
 
     [PlaywrightTest("page-click.spec.ts", "should click a very large button with offset")]
@@ -446,9 +444,8 @@ public async Task ShouldClickAVeryLargeButtonWithOffset()
         await Page.EvalOnSelectorAsync("button", "button => button.style.height = button.style.width = '2000px'");
         await Page.ClickAsync("button", new() { Position = new() { X = 1900, Y = 1910 } });
         Assert.AreEqual("Clicked", await Page.EvaluateAsync<string>("window.result"));
-        // Safari reports border-relative offsetX/offsetY.
-        Assert.AreEqual(TestConstants.IsWebKit ? 1900 + 8 : 1900, await Page.EvaluateAsync<int>("offsetX"));
-        Assert.AreEqual(TestConstants.IsWebKit ? 1910 + 8 : 1910, await Page.EvaluateAsync<int>("offsetY"));
+        Assert.AreEqual(1900, await Page.EvaluateAsync<int>("offsetX"));
+        Assert.AreEqual(1910, await Page.EvaluateAsync<int>("offsetY"));
     }
 
     [PlaywrightTest("page-click.spec.ts", "should click a button in scrolling container with offset")]
@@ -469,9 +466,8 @@ await Page.EvalOnSelectorAsync("button", @"button => {
 
         await Page.ClickAsync("button", new() { Position = new() { X = 1900, Y = 1910 } });
         Assert.AreEqual("Clicked", await Page.EvaluateAsync<string>("window.result"));
-        // Safari reports border-relative offsetX/offsetY.
-        Assert.AreEqual(TestConstants.IsWebKit ? 1900 + 8 : 1900, await Page.EvaluateAsync<int>("offsetX"));
-        Assert.AreEqual(TestConstants.IsWebKit ? 1910 + 8 : 1910, await Page.EvaluateAsync<int>("offsetY"));
+        Assert.AreEqual(1900, await Page.EvaluateAsync<int>("offsetX"));
+        Assert.AreEqual(1910, await Page.EvaluateAsync<int>("offsetY"));
     }
 
     [PlaywrightTest("page-click.spec.ts", "should click the button with offset with page scale")]

src/Playwright.Tests/PopupTests.cs

@@ -129,6 +129,7 @@ await TaskUtils.WhenAll(
     }
 
     [PlaywrightTest("popup.spec.ts", "should inherit touch support from browser context")]
+    [Skip(SkipAttribute.Targets.Firefox)] // https://bugzilla.mozilla.org/show_bug.cgi?id=2014330
     public async Task ShouldInheritTouchSupportFromBrowserContext()
     {
         await using var context = await Browser.NewContextAsync(new()