Skip to content

Commit a40aed8

Browse files
committed
chore: add API compatibility suppressions for IAsyncDisposable return types
1 parent b76113d commit a40aed8

3 files changed

Lines changed: 338 additions & 12 deletions

File tree

src/Playwright.Tests/PageClickTests.cs

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -420,9 +420,8 @@ public async Task ShouldClickTheButtonWithPxBorderWithRelativePoint()
420420
await Page.EvalOnSelectorAsync("button", "button => button.style.borderWidth = '8px'");
421421
await Page.ClickAsync("button", new() { Position = new() { X = 20, Y = 10 } });
422422
Assert.AreEqual("Clicked", await Page.EvaluateAsync<string>("window.result"));
423-
// Safari reports border-relative offsetX/offsetY.
424-
Assert.AreEqual(TestConstants.IsWebKit ? 20 + 8 : 20, await Page.EvaluateAsync<int>("offsetX"));
425-
Assert.AreEqual(TestConstants.IsWebKit ? 10 + 8 : 10, await Page.EvaluateAsync<int>("offsetY"));
423+
Assert.AreEqual(20, await Page.EvaluateAsync<int>("offsetX"));
424+
Assert.AreEqual(10, await Page.EvaluateAsync<int>("offsetY"));
426425
}
427426

428427
[PlaywrightTest("page-click.spec.ts", "should click the button with em border with offset")]
@@ -433,9 +432,8 @@ public async Task ShouldClickTheButtonWithEmBorderWithOffset()
433432
await Page.EvalOnSelectorAsync("button", "button => button.style.fontSize = '12px'");
434433
await Page.ClickAsync("button", new() { Position = new() { X = 20, Y = 10 } });
435434
Assert.AreEqual("Clicked", await Page.EvaluateAsync<string>("window.result"));
436-
// Safari reports border-relative offsetX/offsetY.
437-
Assert.AreEqual(TestConstants.IsWebKit ? 12 * 2 + 20 : 20, await Page.EvaluateAsync<int>("offsetX"));
438-
Assert.AreEqual(TestConstants.IsWebKit ? 12 * 2 + 10 : 10, await Page.EvaluateAsync<int>("offsetY"));
435+
Assert.AreEqual(20, await Page.EvaluateAsync<int>("offsetX"));
436+
Assert.AreEqual(10, await Page.EvaluateAsync<int>("offsetY"));
439437
}
440438

441439
[PlaywrightTest("page-click.spec.ts", "should click a very large button with offset")]
@@ -446,9 +444,8 @@ public async Task ShouldClickAVeryLargeButtonWithOffset()
446444
await Page.EvalOnSelectorAsync("button", "button => button.style.height = button.style.width = '2000px'");
447445
await Page.ClickAsync("button", new() { Position = new() { X = 1900, Y = 1910 } });
448446
Assert.AreEqual("Clicked", await Page.EvaluateAsync<string>("window.result"));
449-
// Safari reports border-relative offsetX/offsetY.
450-
Assert.AreEqual(TestConstants.IsWebKit ? 1900 + 8 : 1900, await Page.EvaluateAsync<int>("offsetX"));
451-
Assert.AreEqual(TestConstants.IsWebKit ? 1910 + 8 : 1910, await Page.EvaluateAsync<int>("offsetY"));
447+
Assert.AreEqual(1900, await Page.EvaluateAsync<int>("offsetX"));
448+
Assert.AreEqual(1910, await Page.EvaluateAsync<int>("offsetY"));
452449
}
453450

454451
[PlaywrightTest("page-click.spec.ts", "should click a button in scrolling container with offset")]
@@ -469,9 +466,8 @@ await Page.EvalOnSelectorAsync("button", @"button => {
469466

470467
await Page.ClickAsync("button", new() { Position = new() { X = 1900, Y = 1910 } });
471468
Assert.AreEqual("Clicked", await Page.EvaluateAsync<string>("window.result"));
472-
// Safari reports border-relative offsetX/offsetY.
473-
Assert.AreEqual(TestConstants.IsWebKit ? 1900 + 8 : 1900, await Page.EvaluateAsync<int>("offsetX"));
474-
Assert.AreEqual(TestConstants.IsWebKit ? 1910 + 8 : 1910, await Page.EvaluateAsync<int>("offsetY"));
469+
Assert.AreEqual(1900, await Page.EvaluateAsync<int>("offsetX"));
470+
Assert.AreEqual(1910, await Page.EvaluateAsync<int>("offsetY"));
475471
}
476472

477473
[PlaywrightTest("page-click.spec.ts", "should click the button with offset with page scale")]

src/Playwright.Tests/PopupTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,7 @@ await TaskUtils.WhenAll(
129129
}
130130

131131
[PlaywrightTest("popup.spec.ts", "should inherit touch support from browser context")]
132+
[Skip(SkipAttribute.Targets.Firefox)] // https://bugzilla.mozilla.org/show_bug.cgi?id=2014330
132133
public async Task ShouldInheritTouchSupportFromBrowserContext()
133134
{
134135
await using var context = await Browser.NewContextAsync(new()

0 commit comments

Comments
 (0)