Skip to content

Enabled Baseline Package Validation #3169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mxschmitt merged 9 commits into from
Jun 3, 2025
Merged

Enabled Baseline Package Validation #3169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ce3c3cf
Enable Package Baseline Validation
304NotModified May 23, 2025
4d40c8b
NoWarn CP0006 - A member was added to an interface without a default …
304NotModified May 23, 2025
4f3d182
Added CompatibilitySuppressions
304NotModified May 23, 2025
941a7c6
Create validate-nuget-packages.yml
304NotModified May 23, 2025
92c3808
Merge branch 'main' into PackageBaselineValidation
304NotModified May 29, 2025
7af5e75
supress breaking errors BindingSource
304NotModified May 30, 2025
a8029a0
Move to PackageValidationBaselineVersion 1.52.0
304NotModified Jun 3, 2025
42ea097
Merge remote-tracking branch 'origin/main' into PackageBaselineValida…
304NotModified Jun 3, 2025
97bab35
Update supressions after update to main
304NotModified Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .github/workflows/validate-nuget-packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: Validate NuGet Packages

on:
push:
branches:
- main
pull_request:
branches:
- main

jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Setup .NET Core
uses: actions/setup-dotnet@v4
with:
dotnet-version: 8.0.x
- name: Download driver
run: ./build.sh --download-driver
- name: Validate NuGet packages
run: dotnet pack ./src/Playwright.sln
2 changes: 2 additions & 0 deletions src/Playwright.MSTest/Playwright.MSTest.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@
<PackageOutputPath>./nupkg</PackageOutputPath>
<IsPackable>true</IsPackable>
<Nullable>enable</Nullable>
<EnablePackageValidation>true</EnablePackageValidation>
<PackageValidationBaselineVersion>1.52.0</PackageValidationBaselineVersion>
</PropertyGroup>

<Import Project="../Common/Version.props" />
Expand Down
2 changes: 2 additions & 0 deletions src/Playwright.NUnit/Playwright.NUnit.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@
<PackageOutputPath>./nupkg</PackageOutputPath>
<IsPackable>true</IsPackable>
<Nullable>enable</Nullable>
<EnablePackageValidation>true</EnablePackageValidation>
<PackageValidationBaselineVersion>1.52.0</PackageValidationBaselineVersion>
</PropertyGroup>

<Import Project="../Common/Version.props" />
Expand Down
2 changes: 2 additions & 0 deletions src/Playwright.TestAdapter/Playwright.TestAdapter.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@
<PackageOutputPath>./nupkg</PackageOutputPath>
<IsPackable>true</IsPackable>
<Nullable>enable</Nullable>
<EnablePackageValidation>true</EnablePackageValidation>
<PackageValidationBaselineVersion>1.52.0</PackageValidationBaselineVersion>
</PropertyGroup>

<Import Project="../Common/Version.props" />
Expand Down
2 changes: 2 additions & 0 deletions src/Playwright.Xunit/Playwright.Xunit.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@
<PackageOutputPath>./nupkg</PackageOutputPath>
<IsPackable>true</IsPackable>
<Nullable>enable</Nullable>
<EnablePackageValidation>true</EnablePackageValidation>
<PackageValidationBaselineVersion>1.52.0</PackageValidationBaselineVersion>
</PropertyGroup>

<Import Project="../Common/Version.props" />
Expand Down
32 changes: 32 additions & 0 deletions src/Playwright/CompatibilitySuppressions.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
<?xml version="1.0" encoding="utf-8"?>
<!-- https://learn.microsoft.com/dotnet/fundamentals/package-validation/diagnostic-ids -->
<Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
<Suppression>
<DiagnosticId>CP0002</DiagnosticId>
<Target>M:Microsoft.Playwright.BindingSource.#ctor</Target>
<Left>lib/netstandard2.0/Microsoft.Playwright.dll</Left>
<Right>lib/netstandard2.0/Microsoft.Playwright.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0002</DiagnosticId>
<Target>M:Microsoft.Playwright.LocatorAriaSnapshotOptions.get_Ref</Target>
<Left>lib/netstandard2.0/Microsoft.Playwright.dll</Left>
<Right>lib/netstandard2.0/Microsoft.Playwright.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0002</DiagnosticId>
<Target>M:Microsoft.Playwright.LocatorAriaSnapshotOptions.set_Ref(System.Nullable{System.Boolean})</Target>
<Left>lib/netstandard2.0/Microsoft.Playwright.dll</Left>
<Right>lib/netstandard2.0/Microsoft.Playwright.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0009</DiagnosticId>
<Target>T:Microsoft.Playwright.BindingSource</Target>
<Left>lib/netstandard2.0/Microsoft.Playwright.dll</Left>
<Right>lib/netstandard2.0/Microsoft.Playwright.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
</Suppressions>
4 changes: 3 additions & 1 deletion src/Playwright/Playwright.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,11 @@
<ReleaseVersion>0.0.0</ReleaseVersion>
<BuildFromSource>True</BuildFromSource>
<AnalysisMode>AllEnabledByDefault</AnalysisMode>
<NoWarn>1701;1702;CS0067;1734;NU5110;NU5111</NoWarn>
<NoWarn>1701;1702;CS0067;1734;NU5110;NU5111;CP0006</NoWarn>
<AssemblyName>Microsoft.Playwright</AssemblyName>
<NoWin32Manifest>true</NoWin32Manifest>
<EnablePackageValidation>true</EnablePackageValidation>
<PackageValidationBaselineVersion>1.52.0</PackageValidationBaselineVersion>
<Nullable>enable</Nullable>
</PropertyGroup>
<Import Project="../Common/Version.props" />
Expand Down
Loading