Skip to content

chore: remove 'nullable disable' leftover #3180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mxschmitt merged 1 commit into from
May 28, 2025
Merged

chore: remove 'nullable disable' leftover #3180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions src/Playwright/Core/Frame.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1039,7 +1039,6 @@ internal class SelectOptionValueProtocol

[JsonPropertyName("index")]
public int? Index { get; set; }
#nullable disable

internal static SelectOptionValueProtocol From(SelectOptionValue value)
{
Expand All @@ -1054,16 +1053,16 @@ internal static SelectOptionValueProtocol From(SelectOptionValue value)

internal class FrameNavigatedEventArgs
{
public string Name { get; set; }
public string Name { get; set; } = null!;

public string Url { get; set; }
public string Url { get; set; } = null!;

public string Error { get; set; }
public string? Error { get; set; }

internal NavigateDocument NewDocument { get; set; }
internal NavigateDocument? NewDocument { get; set; }
}

internal class NavigateDocument
{
public Request Request { get; set; }
public Request? Request { get; set; }
}