Commit 31d2a38
chore: reduce CI flakiness across webkit/macOS, ubuntu, windows
Three independent fixes for recurring CI failures on main:
- test.yml: run the webkit matrix on macos-15-xlarge instead of
macos-latest. macos-latest is the free 3 vCPU / 7 GB M1 runner; the
webkit suite has been crashing window.open() / popup tests on it
every push run. Upstream's webkit matrix has always used xlarge
(tests_secondary.yml). Other browsers stay on macos-latest.
- TestRouteWebSocket: drop the 'error' event listener in setupWS.
WebKit fires a spurious 'error' before 'close' on non-normal
closures (e.g. 1008), which intermittently failed
shouldWorkWithTextMessage with [open, message, error, close]
vs the expected [open, message, close]. The Java port has no
tests that assert on 'error'.
- download_driver.sh: pass --retry 5 --retry-delay 2 -fL to curl,
fixing the windows driver download that occasionally errors with
'curl: (56) schannel: server closed abruptly'.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent b01bf64 commit 31d2a38
3 files changed
Lines changed: 10 additions & 2 deletions
File tree
- .github/workflows
- playwright/src/test/java/com/microsoft/playwright
- scripts
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
21 | 29 | | |
22 | 30 | | |
23 | 31 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
| 48 | + | |
48 | 49 | | |
49 | 50 | | |
50 | 51 | | |
51 | 52 | | |
52 | 53 | | |
53 | 54 | | |
54 | | - | |
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
53 | | - | |
| 53 | + | |
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
| |||
0 commit comments