You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
chore: extract common skill conventions into CLAUDE.md
Move the shared commit/PR conventions and JS-mirroring notes out of the
roll skill into a top-level CLAUDE.md, aligned with the upstream
playwright CLAUDE.md.
Copy file name to clipboardExpand all lines: .claude/skills/playwright-roll/SKILL.md
+2-34Lines changed: 2 additions & 34 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -53,7 +53,7 @@ Rolling includes:
53
53
54
54
## Mimicking the JavaScript implementation
55
55
56
-
The Java client is a port of the JS client in `../playwright/packages/playwright-core/src/client/`. When implementing a new or changed method, always read the corresponding JS file first and mirror its logic:
56
+
The Java client is a port of the JS client in `../playwright/packages/playwright-core/src/client/` (see CLAUDE.md). When implementing a new or changed method, always read the corresponding JS file first and mirror its logic:
Never add Co-Authored-By agents in commit message.
197
-
Never add "Generated with" in commit message.
198
-
Branch naming for issue fixes: `fix-<issue-number>`
199
-
200
-
## Tips & Tricks
201
-
- Project checkouts are in the parent directory (`../`).
202
-
- use the "gh" cli to interact with GitHub
170
+
Commit and PR conventions live in CLAUDE.md. Use the running notes file as the PR body: list each upstream PR ported, each skipped (with reason), and each verified-already-supported.
The Java client is a port of the JavaScript client in `../playwright/packages/playwright-core/src/client/`. When implementing or changing a method, read the corresponding JS file first and mirror its logic.
4
+
5
+
Project checkouts (including the upstream `playwright` repo) live in the parent directory (`../`). Use the `gh` cli to interact with GitHub.
Never add Co-Authored-By agents in commit message.
37
+
Never add "Generated with" in commit message.
38
+
Never add test plan to PR description. Keep PR description short — a few bullet points at most.
39
+
Branch naming for issue fixes: `fix-<issue-number>`.
40
+
41
+
**Never amend commits.** Always create a new commit for follow-up changes, even when iterating on an open PR. Amending rewrites history and forces a force-push, losing the incremental review trail. Only amend if the user explicitly says so.
42
+
43
+
**Never `git push` without an explicit instruction to push.** Applies even when a PR is already open for the branch — additional commits are immediately visible to reviewers. Commit locally, report what was committed, and wait. Only push when the user's message contains "push", "upload", "create PR", "ship it", or equivalent.
0 commit comments