Skip to content

Commit 4fb8a95

Browse files
committed
chore: trim comments
1 parent 1d06a09 commit 4fb8a95

5 files changed

Lines changed: 4 additions & 9 deletions

File tree

playwright/src/main/java/com/microsoft/playwright/impl/ChannelOwner.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,8 +110,7 @@ WaitableResult<JsonElement> sendMessageAsync(String method, JsonObject params) {
110110
return connection.sendMessageAsync(guid, method, params);
111111
}
112112

113-
// Fire-and-forget: the server intentionally never replies to this message,
114-
// so silently drop it if the object was collected.
113+
// Fire-and-forget: silently drop if the object was collected.
115114
void sendMessageNoReply(String method, JsonObject params) {
116115
if (wasCollected) {
117116
return;

playwright/src/main/java/com/microsoft/playwright/impl/Connection.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ public WaitableResult<JsonElement> sendMessageAsync(String guid, String method,
136136
return internalSendMessage(guid, method, params, true, true);
137137
}
138138

139-
// Fire-and-forget: the server intentionally never replies to this message.
139+
// Fire-and-forget: the server never replies.
140140
public void sendMessageNoReply(String guid, String method, JsonObject params) {
141141
internalSendMessage(guid, method, params, false, false);
142142
}
@@ -269,8 +269,6 @@ private void dispatch(Message message) {
269269
} else {
270270
exception = new DriverException(message.error.error + callLog);
271271
}
272-
// The server attaches errorDetails to errors of the methods that declare them
273-
// in the protocol (currently only Frame.expect and Page.expectScreenshot).
274272
if (message.errorDetails != null) {
275273
exception = new ServerErrorWithDetails(exception, message.errorDetails, message.log);
276274
}

playwright/src/main/java/com/microsoft/playwright/impl/Protocol.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,6 @@ static class Received {
122122
List<String> log;
123123
}
124124

125-
// Sent by the server as `errorDetails` when Frame.expect fails.
126125
class FrameExpectErrorDetails {
127126
FrameExpectResult.Received received;
128127
Boolean timedOut;

playwright/src/main/java/com/microsoft/playwright/impl/ServerErrorWithDetails.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
import java.util.ArrayList;
2525
import java.util.List;
2626

27-
// Server error with the structured details declared in the protocol for the failed method.
2827
class ServerErrorWithDetails extends PlaywrightException {
2928
private final JsonObject errorDetails;
3029
private final JsonArray log;
@@ -35,7 +34,7 @@ class ServerErrorWithDetails extends PlaywrightException {
3534
this.log = log;
3635
}
3736

38-
// Used to rethrow with the stack trace of the calling thread, see WaitableResult.get().
37+
// Rethrown with the calling thread's stack trace, see WaitableResult.get().
3938
ServerErrorWithDetails(ServerErrorWithDetails cause) {
4039
super(cause.getMessage(), cause);
4140
this.errorDetails = cause.errorDetails;

tools/api-generator/src/main/java/com/microsoft/playwright/tools/ApiGenerator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -997,7 +997,7 @@ Map<String, TypeDefinition> topLevelTypes() {
997997
}
998998

999999
void writeTo(List<String> output, String offset) {
1000-
// Interfaces with a static factory method delegating to the Impl class, see Method.writeTo.
1000+
// Interfaces with a static factory method, see Method.writeTo.
10011001
if (asList("Playwright", "FormData", "RequestOptions").contains(jsonName) && methods.stream().anyMatch(m -> "create".equals(m.jsonName))) {
10021002
output.add("import com.microsoft.playwright.impl." + jsonName + "Impl;");
10031003
}

0 commit comments

Comments
 (0)