Skip to content

Commit 8a07471

Browse files
yury-sclaude
andcommitted
test: update click offset expectations for WebKit roll 2249
WebKit no longer reports border-relative offsetX/offsetY, so remove the conditional isWebKit() branches. All browsers now return the same values (4c062ce upstream). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 4593426 commit 8a07471

File tree

1 file changed

+8
-12
lines changed

1 file changed

+8
-12
lines changed

playwright/src/test/java/com/microsoft/playwright/TestClick.java

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -355,9 +355,8 @@ void shouldClickTheButtonWithPxBorderWithOffset() {
355355
page.evalOnSelector("button", "button => button.style.borderWidth = '8px'");
356356
page.click("button", new Page.ClickOptions().setPosition(20, 10));
357357
assertEquals(page.evaluate("result"), "Clicked");
358-
// Safari reports border-relative offsetX/offsetY.
359-
assertEquals(isWebKit() ? 20 + 8 : 20, page.evaluate("offsetX"));
360-
assertEquals(isWebKit() ? 10 + 8 : 10, page.evaluate("offsetY"));
358+
assertEquals(20, page.evaluate("offsetX"));
359+
assertEquals(10, page.evaluate("offsetY"));
361360
}
362361

363362
@Test
@@ -367,9 +366,8 @@ void shouldClickTheButtonWithEmBorderWithOffset() {
367366
page.evalOnSelector("button", "button => button.style.fontSize = '12px'");
368367
page.click("button", new Page.ClickOptions().setPosition(20, 10));
369368
assertEquals("Clicked", page.evaluate("result"));
370-
// Safari reports border-relative offsetX/offsetY.
371-
assertEquals(isWebKit() ? 12 * 2 + 20 : 20, page.evaluate("offsetX"));
372-
assertEquals(isWebKit() ? 12 * 2 + 10 : 10, page.evaluate("offsetY"));
369+
assertEquals(20, page.evaluate("offsetX"));
370+
assertEquals(10, page.evaluate("offsetY"));
373371
}
374372

375373
@Test
@@ -379,9 +377,8 @@ void shouldClickAVeryLargeButtonWithOffset() {
379377
page.evalOnSelector("button", "button => button.style.height = button.style.width = '2000px'");
380378
page.click("button", new Page.ClickOptions().setPosition(1900, 1910));
381379
assertEquals("Clicked", page.evaluate("() => window['result']"));
382-
// Safari reports border-relative offsetX/offsetY.
383-
assertEquals(isWebKit() ? 1900 + 8 : 1900, page.evaluate("offsetX"));
384-
assertEquals(isWebKit() ? 1910 + 8 : 1910, page.evaluate("offsetY"));
380+
assertEquals(1900, page.evaluate("offsetX"));
381+
assertEquals(1910, page.evaluate("offsetY"));
385382
}
386383

387384
@Test
@@ -400,9 +397,8 @@ void shouldClickAButtonInScrollingContainerWithOffset() {
400397
"}");
401398
page.click("button", new Page.ClickOptions().setPosition(1900, 1910));
402399
assertEquals("Clicked", page.evaluate("() => window['result']"));
403-
// Safari reports border-relative offsetX/offsetY.
404-
assertEquals(isWebKit() ? 1900 + 8 : 1900, page.evaluate("offsetX"));
405-
assertEquals(isWebKit() ? 1910 + 8 : 1910, page.evaluate("offsetY"));
400+
assertEquals(1900, page.evaluate("offsetX"));
401+
assertEquals(1910, page.evaluate("offsetY"));
406402
}
407403

408404
private static void expectCloseTo(double expected, double actual) {

0 commit comments

Comments
 (0)