Skip to content

Commit f702494

Browse files
committed
updated instructions
1 parent d30882a commit f702494

File tree

1 file changed

+32
-0
lines changed

1 file changed

+32
-0
lines changed

.claude/skills/playwright-roll/SKILL.md

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,38 @@ Common patterns:
104104

105105
**Run the full suite to catch regressions, re-run flaky failures in isolation.** Some tests (e.g., `TestClientCertificates#shouldKeepSupportingHttp`) time out only under heavy parallel load. Run the failing test alone to confirm it's flaky before investigating further.
106106

107+
## Commit Convention
108+
109+
Semantic commit messages: `label(scope): description`
110+
111+
Labels: `fix`, `feat`, `chore`, `docs`, `test`, `devops`
112+
113+
```bash
114+
git checkout -b fix-39562
115+
# ... make changes ...
116+
git add <changed-files>
117+
git commit -m "$(cat <<'EOF'
118+
fix(proxy): handle SOCKS proxy authentication
119+
120+
Fixes: https://github.com/microsoft/playwright-java/issues/39562
121+
EOF
122+
)"
123+
git push origin fix-39562
124+
gh pr create --repo microsoft/playwright-java --head username:fix-39562 \
125+
--title "fix(proxy): handle SOCKS proxy authentication" \
126+
--body "$(cat <<'EOF'
127+
## Summary
128+
- <describe the change very! briefly>
129+
130+
Fixes https://github.com/microsoft/playwright-java/issues/39562
131+
EOF
132+
)"
133+
```
134+
135+
Never add Co-Authored-By agents in commit message.
136+
Never add "Generated with" in commit message.
137+
Branch naming for issue fixes: `fix-<issue-number>`
138+
107139
## Tips & Tricks
108140
- Project checkouts are in the parent directory (`../`).
109141
- When updating checkboxes, store the issue content into /tmp and edit it there, then update the issue based on the file

0 commit comments

Comments
 (0)