Skip to content

fix: Replaced classLoader in DriverJar #1811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yury-s merged 8 commits into from
Jul 31, 2025
Merged

fix: Replaced classLoader in DriverJar #1811

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a7830eb
fix: Replaced classLoader in DriverJar
ArcticFoox Jun 24, 2025
2b8f04d
test: add classLoader test
ArcticFoox Jul 4, 2025
3c925b1
test: add classloader docker ci test
ArcticFoox Jul 21, 2025
04b40cf
refactor: delete classloader test and add async execution support in …
ArcticFoox Jul 24, 2025
999cef6
refactor: simplify if statement
ArcticFoox Jul 25, 2025
2b34498
fix: update docker test workflow to manage container lifecycle
ArcticFoox Jul 26, 2025
ef25b16
fix: add execute permission for async test script in docker workflow
ArcticFoox Jul 29, 2025
3da9be6
fix: delete permission grant step and add executable bit in package_a…
ArcticFoox Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/test_docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,3 +36,9 @@ jobs:
run: |
CONTAINER_ID="$(docker run --rm -e CI --ipc=host -v $(pwd):/root/playwright --name playwright-docker-test -d -t playwright-java:localbuild-${{ matrix.flavor }} /bin/bash)"
docker exec "${CONTAINER_ID}" /root/playwright/tools/test-local-installation/create_project_and_run_tests.sh
Copy link
Copy Markdown
Member

@yury-s yury-s Jul 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid the docker test failures let's just add docker stop "${CONTAINER_ID}" to this (and the new) step to shutdown the container after the test has finished. Or better yet, since the container is the same in both steps, you can move its creation in a separate step and then use its CONTAINER_ID without relaunching, something like

 - name: Start container
        run: |
          CONTAINER_ID=$(docker run --rm -e CI --ipc=host -v "$(pwd)":/root/playwright --name playwright-docker-test -d -t playwright-java:localbuild-${{ matrix.flavor }} /bin/bash)
          echo "CONTAINER_ID=$CONTAINER_ID" >> $GITHUB_ENV

      - name: Run test in container
        run: |
          docker exec "$CONTAINER_ID" /root/playwright/tools/test-local-installation/create_project_and_run_tests.sh

      - name: Test ClassLoader
        run: |
          docker exec "${CONTAINER_ID}" /root/playwright/tools/test-spring-boot-starter/package_and_run_async_test.sh

Copy link
Copy Markdown
Contributor Author

@ArcticFoox ArcticFoox Jul 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added example code and stop step

- name: Test ClassLoader
env:
BROWSER: ${{ matrix.browser }}
Comment thread
yury-s marked this conversation as resolved.
Outdated
run: |
CONTAINER_ID="$(docker run --rm -e CI --ipc=host -v $(pwd):/root/playwright --name playwright-docker-test -d -t playwright-java:localbuild-${{ matrix.flavor }} /bin/bash)"
docker exec "${CONTAINER_ID}" /root/playwright/tools/test-spring-boot-starter/package_and_run_async_test.sh
2 changes: 1 addition & 1 deletion driver-bundle/src/main/java/com/microsoft/playwright/impl/driver/jar/DriverJar.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ private FileSystem initFileSystem(URI uri) throws IOException {
}

public static URI getDriverResourceURI() throws URISyntaxException {
ClassLoader classloader = Thread.currentThread().getContextClassLoader();
ClassLoader classloader = DriverJar.class.getClassLoader();
return classloader.getResource("driver/" + platformDir()).toURI();
}

Expand Down
8 changes: 8 additions & 0 deletions tools/test-spring-boot-starter/package_and_run_async_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
#!/bin/bash

set -e
set +x

cd "$(dirname "$0")"
mvn package -D skipTests --no-transfer-progress
java -jar target/test-spring-boot-starter*.jar --async
20 changes: 20 additions & 0 deletions ...st-spring-boot-starter/src/main/java/com/microsoft/playwright/springboottest/TestApp.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
import org.springframework.boot.SpringApplication;
import org.springframework.boot.autoconfigure.SpringBootApplication;

import java.util.concurrent.CompletableFuture;

@SpringBootApplication
public class TestApp implements CommandLineRunner {

Expand All @@ -14,6 +16,24 @@ public static void main(String[] args) {

@Override
public void run(String... args) {
if (args.length == 0) {
Copy link
Copy Markdown
Member

@yury-s yury-s Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about the following, so that each version is called from exactly one branch?

    if (Arrays.asList(args).contains("--async")) {
      runAsync();
    } else {
      runSync();
    }

Copy link
Copy Markdown
Contributor Author

@ArcticFoox ArcticFoox Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That’s a great suggestion.
I’ve updated the implementation accordingly and committed the changes.

Copy link
Copy Markdown
Member

@yury-s yury-s Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing this and for your patience addressing all the review comments!

Copy link
Copy Markdown
Contributor Author

@ArcticFoox ArcticFoox Jul 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m glad I had the opportunity to contribute. Since this was my first open source contribution, I struggled quite a bit, but your reviews and comments were a huge help. Thank you!

runSync();
} else {
if ("--async".equals(args[0])) {
runAsync();
}
else {
runSync();
}
}
Copy link
Copy Markdown
Contributor Author

@ArcticFoox ArcticFoox Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I modified the if statement to prevent an IndexOutOfBoundsException.

}

private void runAsync() {
CompletableFuture<Void> voidCompletableFuture = CompletableFuture.runAsync(this::runSync);
voidCompletableFuture.join();
}

private void runSync() {
try (Playwright playwright = Playwright.create()) {
BrowserType browserType = getBrowserTypeFromEnv(playwright);
System.out.println("Running test with " + browserType.name());
Expand Down
Loading