chore: roll driver to 1.61.0-beta-1781285686000#1929
Open
yury-s wants to merge 4 commits into
Open
Conversation
Ported upstream changes: - #40843 page.localStorage()/sessionStorage() (WebStorage API) - #40849 context.credentials() WebAuthn virtual authenticator - #40932 APIResponse.securityDetails()/serverAddr() - #41162 ScreencastFrame.timestamp() - #40916 screencast cursor and size options - #40844 comma-separated testIdAttribute (getByTestId now uses internal:testid) - #40718 waitForEventInfo replaced with fire-and-forget __waitInfo__ - #40780 protocol Page.close split into close and runBeforeUnload - #40801 Frame.expect failures are now protocol errors with errorDetails - #41014 connectOverCDP allowed for WebKit, artifactsDir option
dgozman
approved these changes
Jun 12, 2026
- connectOverCDP is now supported in WebKit: skip the not-chromium test there and expect the new error message - accept all close-time messages in waitForNavigation-after-disconnect - wait 2s for page errors to accumulate, mirrors upstream #38378 - regenerate firefox screenshot expectations for Firefox 151
- accept all close-time error message variants in waitForNavigation-after-disconnect, the surfaced message depends on which call hits the closed connection first - shouldDetachWhenPageCloses: only check that detach throws, like the upstream test - skip @tempdir cleanup for user data dirs: on Windows Chromium 149 keeps chrome_debug.log locked briefly after close
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1.60.0to1.61.0-beta-1781285686000.Ported:
page.localStorage()/page.sessionStorage()— newWebStorageinterface.context.credentials()WebAuthn virtual authenticator — newCredentialsinterface.APIResponse.securityDetails()/serverAddr().ScreencastFrame.timestamp(); #40916: screencastsize/cursoroptions.setTestIdAttribute—getByTestIdnow emits theinternal:testidengine like the JS client.waitForEventInforeplaced with fire-and-forget__waitInfo__(new no-reply send path inConnection).Page.closesplit intocloseandrunBeforeUnload.Frame.expectfailures are now protocol errors witherrorDetails— wrapped intoServerErrorWithDetailsand converted back to the expect result inFrameImpl.connectOverCDPallowed for WebKit;artifactsDiroption flows through options serialization.Verified no client change needed: #40833, #40966, #41091, #41266. Skipped: JS-internal/electron/MCP/codegen changes and features reverted upstream (#40748, #40869, #40798, #41136).