chore: require playwright>=1.60 in CI and unskip 1.60 tests (#313)

* chore: require playwright>=1.60 in CI and unskip 1.60 tests

Playwright Python 1.60 has been released, so the tests gated on it can
now run. Pin the dev dependency in local-requirements.txt so CI installs
a compatible version; the package's runtime requirement is unchanged.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* test(connect_options): adapt to Playwright 1.59.1+ connect() API

BrowserType.connect() renamed its first parameter from ws_endpoint to
endpoint (positional) in microsoft/playwright-python#3050. The test
also needs to look at stderr from the subprocess pytester run, since
the WebSocket error log lands there.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* test: set PYTHONIOENCODING=utf-8 for pytester subprocesses

Pytester decodes subprocess stdout as utf-8, but on Windows the default
stdout encoding is cp1252. When Playwright's assertion failure messages
contain non-ASCII characters (e.g. unicode arrows / multiplication
signs), pytester raises UnicodeDecodeError. Force utf-8 in child Python
processes.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: Skn0tt

local-requirements.txt

@@ -9,3 +9,4 @@ pre-commit==4.0.1
 Django==4.2.24
 pytest-xdist==3.8.0
 pytest-asyncio==1.3.0
+playwright>=1.60

tests/conftest.py

@@ -41,6 +41,10 @@ def pytest_configure(config: Any) -> None:
 
 os.environ["PLAYWRIGHT_BROWSERS_PATH"] = playwright_browser_path
 
+# Ensure subprocess pytester runs (and any child python processes) emit utf-8
+# on stdout/stderr so pytester's utf-8 decoding doesn't break on Windows.
+os.environ["PYTHONIOENCODING"] = "utf-8"
+
 
 class HTTPTestServer:
     PREFIX = ""

tests/test_asyncio.py

@@ -1045,7 +1045,6 @@ def test_with_page(page):
     ]
 
 
-@pytest.mark.skip(reason="requires 1.60")
 def test_connect_options_should_work(testdir: pytest.Testdir) -> None:
     server_process = None
     try:
@@ -1056,7 +1055,7 @@ def test_connect_options_should_work(testdir: pytest.Testdir) -> None:
             @pytest.fixture(scope="session")
             def connect_options():
                 return {
-                    "ws_endpoint": "ws://localhost:1234",
+                    "endpoint": "ws://localhost:1234",
                 }
             """
         )
@@ -1070,7 +1069,7 @@ async def test_connect_options(page):
             """
         )
         result = testdir.runpytest()
-        assert "connect ECONNREFUSED" in "".join(result.outlines)
+        assert "connect ECONNREFUSED" in "\n".join(result.outlines + result.errlines)
         server_process = subprocess.Popen(
             ["playwright", "run-server", "--port=1234"],
             stdout=subprocess.PIPE,
@@ -1111,7 +1110,6 @@ async def test_soft(page):
     assert any("goodbye" in line for line in result.outlines)
 
 
-@pytest.mark.skip(reason="requires 1.60")
 def test_soft_assertion_multiple_failures_exception_group(
     testdir: pytest.Testdir,
 ) -> None:
@@ -1133,7 +1131,6 @@ async def test_soft(page):
     assert "first" in out and "second" in out
 
 
-@pytest.mark.skip(reason="requires 1.60")
 def test_soft_assertion_passes_when_all_match(testdir: pytest.Testdir) -> None:
     testdir.makepyfile(
         """
@@ -1150,7 +1147,6 @@ async def test_soft(page):
     result.assert_outcomes(passed=1)
 
 
-@pytest.mark.skip(reason="requires 1.60")
 def test_soft_assertion_does_not_shadow_body_failure(
     testdir: pytest.Testdir,
 ) -> None:

tests/test_sync.py

@@ -1035,7 +1035,6 @@ def test_with_page(page):
     ]
 
 
-@pytest.mark.skip(reason="requires 1.60")
 def test_connect_options_should_work(testdir: pytest.Testdir) -> None:
     server_process = None
     try:
@@ -1046,7 +1045,7 @@ def test_connect_options_should_work(testdir: pytest.Testdir) -> None:
             @pytest.fixture(scope="session")
             def connect_options():
                 return {
-                    "ws_endpoint": "ws://localhost:1234",
+                    "endpoint": "ws://localhost:1234",
                 }
             """
         )
@@ -1057,7 +1056,7 @@ def test_connect_options(page):
             """
         )
         result = testdir.runpytest()
-        assert "connect ECONNREFUSED" in "".join(result.outlines)
+        assert "connect ECONNREFUSED" in "\n".join(result.outlines + result.errlines)
         server_process = subprocess.Popen(
             ["playwright", "run-server", "--port=1234"],
             stdout=subprocess.PIPE,
@@ -1095,7 +1094,6 @@ def test_soft(page):
     assert any("goodbye" in line for line in result.outlines)
 
 
-@pytest.mark.skip(reason="requires 1.60")
 def test_soft_assertion_multiple_failures_exception_group(
     testdir: pytest.Testdir,
 ) -> None:
@@ -1115,7 +1113,6 @@ def test_soft(page):
     assert "first" in out and "second" in out
 
 
-@pytest.mark.skip(reason="requires 1.60")
 def test_soft_assertion_passes_when_all_match(testdir: pytest.Testdir) -> None:
     testdir.makepyfile(
         """
@@ -1130,7 +1127,6 @@ def test_soft(page):
     result.assert_outcomes(passed=1)
 
 
-@pytest.mark.skip(reason="requires 1.60")
 def test_soft_assertion_does_not_shadow_body_failure(
     testdir: pytest.Testdir,
 ) -> None: