Skip to content

Commit 20c0c6b

Browse files
committed
Omit get_frame_info() from the stack trace
1 parent 2745f55 commit 20c0c6b

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

playwright/_impl/_connection.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -516,20 +516,22 @@ def needs_full_stack_trace(self) -> bool:
516516
def get_frame_info(self) -> Generator[FrameInfo]:
517517
current_frame = inspect.currentframe()
518518

519+
if current_frame is None:
520+
return
521+
522+
# Don't include the current method ("get_frame_info()") in the callstack
523+
current_frame = current_frame.f_back
524+
519525
while current_frame:
520526
traceback_info = inspect.getframeinfo(current_frame, 0)
521-
# TODO: Used to be *frameinfo, but I couldn't figure out how to get the type checking to work correctly
522-
# frameinfo = (current_frame,) + traceback_info
523-
# yield FrameInfo(*frameinfo)
524-
# yield FrameInfo(cast(inspect.FrameType, *frameinfo))
527+
525528
yield FrameInfo(
526529
current_frame,
527530
traceback_info.filename,
528531
traceback_info.lineno,
529532
traceback_info.function,
530533
traceback_info.code_context,
531534
traceback_info.index,
532-
# positions=current_frame.positions,
533535
)
534536

535537
current_frame = current_frame.f_back

0 commit comments

Comments
 (0)