More timeout operation fixes

Author: agg23

playwright/_impl/_frame.py

@@ -370,14 +370,10 @@ async def is_enabled(
         )
 
     async def is_hidden(self, selector: str, strict: bool = None) -> bool:
-        return await self._channel.send(
-            "isHidden", self._locals_to_params_with_timeout(locals())
-        )
+        return await self._channel.send("isHidden", locals_to_params(locals()))
 
     async def is_visible(self, selector: str, strict: bool = None) -> bool:
-        return await self._channel.send(
-            "isVisible", self._locals_to_params_with_timeout(locals())
-        )
+        return await self._channel.send("isVisible", locals_to_params(locals()))
 
     async def dispatch_event(
         self,
@@ -865,5 +861,6 @@ def _locals_to_params_with_navigation_timeout(self, args: Dict) -> Dict:
     def _locals_to_params_without_timeout(self, args: Dict) -> Dict:
         params = locals_to_params(locals())
         # Timeout is deprecated and does nothing
-        del params["timeout"]
+        if "timeout" in params:
+            del params["timeout"]
         return params

playwright/_impl/_locator.py

@@ -191,7 +191,7 @@ async def evaluate(
         )
 
     async def evaluate_all(self, expression: str, arg: Serializable = None) -> Any:
-        params = self._locals_to_params_with_timeout(locals())
+        params = locals_to_params(locals())
         return await self._frame.eval_on_selector_all(self._selector, **params)
 
     async def evaluate_handle(
@@ -500,15 +500,15 @@ async def is_enabled(self, timeout: float = None) -> bool:
         )
 
     async def is_hidden(self, timeout: float = None) -> bool:
-        params = self._locals_to_params_with_timeout(locals())
+        params = self._locals_to_params_without_timeout(locals())
         return await self._frame.is_hidden(
             self._selector,
             strict=True,
             **params,
         )
 
     async def is_visible(self, timeout: float = None) -> bool:
-        params = self._locals_to_params_with_timeout(locals())
+        params = self._locals_to_params_without_timeout(locals())
         return await self._frame.is_visible(
             self._selector,
             strict=True,
@@ -742,6 +742,13 @@ def _locals_to_params_with_timeout(self, args: Dict) -> Dict:
         params["timeout"] = self._frame._timeout(params.get("timeout"))
         return params
 
+    def _locals_to_params_without_timeout(self, args: Dict) -> Dict:
+        params = locals_to_params(args)
+        # Timeout is deprecated and does nothing
+        if "timeout" in params:
+            del params["timeout"]
+        return params
+
 
 class FrameLocator:
     def __init__(self, frame: "Frame", frame_selector: str) -> None:

tests/async/test_tracing.py

@@ -379,9 +379,9 @@ async def test_should_show_tracing_group_in_action_list(
         await trace_viewer.expand_action("inner group 1")
         await expect(trace_viewer.action_titles).to_have_text(
             [
-                re.compile(r"New page"),
+                re.compile(r"Create page"),
                 re.compile(r"outer group"),
-                re.compile(r"Navigate to data:"),
+                re.compile(r"Navigate to \"data:\""),
                 re.compile(r"inner group 1"),
                 re.compile(r"Click"),
                 re.compile(r"inner group 2"),

tests/sync/test_tracing.py

@@ -378,9 +378,9 @@ def test_should_show_tracing_group_in_action_list(
         trace_viewer.expand_action("inner group 1")
         expect(trace_viewer.action_titles).to_have_text(
             [
-                re.compile(r"New page"),
+                re.compile(r"Create page"),
                 re.compile(r"outer group"),
-                re.compile(r"Navigate to data:"),
+                re.compile(r"Navigate to \"data:\""),
                 re.compile(r"inner group 1"),
                 re.compile(r"Click"),
                 re.compile(r"inner group 2"),