chore(roll): v1.61.0 (#3102)

Author: Skn0tt

.claude/skills/playwright-roll/SKILL.md

@@ -27,21 +27,6 @@ The upstream documentation source of truth is `docs/src/api/*.md` in the playwri
 
 > **The mistake the 1.59 roll made twice over:** classifying things as "internal tooling, N/A for Python" based on the *name* of the API (Screencast, Debugger, pickLocator, clearConsoleMessages, artifactsDir, …). Almost all of those had empty `langs: {}` in `api.json` and were real Python APIs. Sounding tooling-y is not a `langs` filter. **The `langs` field on the member in `api.json` is the only authoritative signal.** When in doubt, dump it (see "Verifying classifications" below).
 
-## Pre-flight
-
-You will need two checkouts in the parent directory:
-- `~/code/playwright-python` — this repo.
-- `~/code/playwright` — the upstream playwright monorepo (used read-only for diffing).
-
-Bring upstream up to date and ensure release branches/tags are present:
-
-```sh
-git -C ~/code/playwright fetch --tags
-git -C ~/code/playwright fetch origin 'release-*:release-*'
-```
-
-There is sometimes no `vX.Y.0` tag for the latest release (the bots cut release branches first and tag later). Anchor on commits, not tags — see "Identify the commit range" below.
-
 ## Process
 
 ### 1. Set up the env
@@ -76,18 +61,29 @@ build + per-platform Node downloads).
 
 ### 3. Identify the commit range
 
+The build step (step 2) clones the upstream monorepo into `driver/playwright-src`.
+Bring it up to date and ensure release branches/tags are present before walking
+the range:
+
+```sh
+git -C driver/playwright-src fetch --tags
+git -C driver/playwright-src fetch origin 'release-*:release-*'
+```
+
+There is sometimes no `vX.Y.0` tag for the latest release (the bots cut release branches first and tag later). Anchor on commits, not tags.
+
 The diff range is "every commit on the new release branch since the previous release was cut". Anchor commits:
 
 - **Previous release end**: the `chore: bump version to vX.Y.0-next` commit on `main`. That commit is the first commit *after* the previous release (X.Y-1) was cut. Use its parent (`<sha>~1`) as the lower bound.
   ```sh
-  git -C ~/code/playwright log --all --grep="bump version to v" --oneline | head
+  git -C driver/playwright-src log --all --grep="bump version to v" --oneline | head
   ```
 - **New release end**: the tip of `release-<new>` (or the matching tag if it exists).
 
 Save the commit list, oldest first, scoped to `docs/src/api/`:
 
 ```sh
-git -C ~/code/playwright log <prev-anchor>~1..release-<new> --oneline --reverse -- docs/src/api > /tmp/roll-<new>-commits.md
+git -C driver/playwright-src log <prev-anchor>~1..release-<new> --oneline --reverse -- docs/src/api > /tmp/roll-<new>-commits.md
 ```
 
 A normal roll yields 50–100 commits. If you see 0 or thousands, the range is wrong.
@@ -99,7 +95,7 @@ Format the file as a markdown checklist and add the standard preamble (status le
 For each commit, in chronological order:
 
 ```sh
-git -C ~/code/playwright show <sha> -- docs/src/api/
+git -C driver/playwright-src show <sha> -- docs/src/api/
 ```
 
 Look for:
@@ -144,7 +140,7 @@ A few rules of thumb that catch most "actually a PORT" cases:
 
 #### PORT
 
-Implement the change in `playwright/_impl/<module>.py`. Use the upstream JS implementation as a reference: `~/code/playwright/packages/playwright-core/src/client/<module>.ts`. Translate idioms:
+Implement the change in `playwright/_impl/<module>.py`. Use the upstream JS implementation as a reference: `driver/playwright-src/packages/playwright-core/src/client/<module>.ts`. Translate idioms:
 
 | Upstream JS | Python |
 |---|---|
@@ -285,7 +281,7 @@ Class names use the upstream PascalCase (`BrowserContext`, `BrowserType`); metho
 - **A cluster of suppressions on the same class is a smell.** If you're about to add five `Method not implemented: Foo.*` lines, you're almost certainly looking at a class that needs to be implemented. Implement the whole thing once and the suppressions disappear.
 - **Watch for revert pairs in the same range.** 1.59 added and reverted `Browser.isRemote` (#39613 / #39620) inside the same release. Walking chronologically lets you skip the add when you see the revert later.
 - **Watch for rename-revert pairs.** 1.59 had `Locator.normalize` → `Locator.toCode` (#39648) → `Locator.normalize` (#39754). Final state wins; only port the last.
-- **Doc renames almost always include a wire-protocol rename.** Whenever you see `### param: X.y.oldName` → `### param: X.y.newName` in a doc commit, also `git -C ~/code/playwright show <sha> -- packages/protocol/src/protocol.yml` and the corresponding `*Dispatcher.ts` file. If the wire field changed too, the channel-send dict key in `_impl/` must change. Suppressing the doc-side mismatch is hiding a real bug — the previous Python code is silently sending an unknown field that the new server ignores.
+- **Doc renames almost always include a wire-protocol rename.** Whenever you see `### param: X.y.oldName` → `### param: X.y.newName` in a doc commit, also `git -C driver/playwright-src show <sha> -- packages/protocol/src/protocol.yml` and the corresponding `*Dispatcher.ts` file. If the wire field changed too, the channel-send dict key in `_impl/` must change. Suppressing the doc-side mismatch is hiding a real bug — the previous Python code is silently sending an unknown field that the new server ignores.
 - **TypedDicts beat `Dict[str, X]` for any structured return.** When the docs describe a return as `[Object]` with named fields (or even `[Object=Foo]`), define a `TypedDict` in `_api_structures.py`, re-export from both public `__init__.py` files, and use it. Zero runtime cost (it's still a `dict`), and the doc generator's type comparator matches by structure via `get_type_hints`.
 - **Positional renames are free.** A param with no default before any `*` separator is positional-or-keyword in Python, but realistic call sites pass it positionally. Renaming such a param doesn't break callers.
 - **The "Backport changes" GitHub issue can be misleading.** In the 1.59 roll its checkboxes were all marked `[x]` with annotations like "✅ IMPLEMENTED", but several of those features had not actually been merged into the Python port. Trust the `docs/src/api/` walk over the issue.

DRIVER_SHA

@@ -1 +1 @@
-87bb9ddbd78f329df18c2b24847bc9409240cd07
+1cc5a90cfa3eaa430b1a991963100f95126caa47

README.md

@@ -4,9 +4,9 @@ Playwright is a Python library to automate [Chromium](https://www.chromium.org/H
 
 |          | Linux | macOS | Windows |
 |   :---   | :---: | :---: | :---:   |
-| Chromium <!-- GEN:chromium-version -->148.0.7778.96<!-- GEN:stop --> | ✅ | ✅ | ✅ |
-| WebKit <!-- GEN:webkit-version -->26.4<!-- GEN:stop --> | ✅ | ✅ | ✅ |
-| Firefox <!-- GEN:firefox-version -->150.0.2<!-- GEN:stop --> | ✅ | ✅ | ✅ |
+| Chromium <!-- GEN:chromium-version -->149.0.7827.55<!-- GEN:stop --> | ✅ | ✅ | ✅ |
+| WebKit <!-- GEN:webkit-version -->26.5<!-- GEN:stop --> | ✅ | ✅ | ✅ |
+| Firefox <!-- GEN:firefox-version -->151.0<!-- GEN:stop --> | ✅ | ✅ | ✅ |
 
 ## Documentation
 

playwright/_impl/_api_structures.py

@@ -234,11 +234,12 @@ class FrameExpectOptions(TypedDict, total=False):
     pseudo: Optional[str]
 
 
-class FrameExpectResult(TypedDict):
+class FrameExpectResult(TypedDict, total=False):
     matches: bool
     received: Any
-    log: List[str]
+    log: Optional[List[str]]
     errorMessage: Optional[str]
+    timedOut: Optional[bool]
 
 
 AriaRole = Literal[
@@ -344,7 +345,21 @@ class DebuggerPausedDetails(TypedDict):
     title: str
 
 
+class ScreencastSize(TypedDict):
+    width: int
+    height: int
+
+
+class VirtualCredential(TypedDict):
+    id: str
+    rpId: str
+    userHandle: str
+    privateKey: str
+    publicKey: str
+
+
 class ScreencastFrame(TypedDict):
     data: bytes
+    timestamp: float
     viewportWidth: int
     viewportHeight: int

playwright/_impl/_browser_context.py

@@ -46,6 +46,7 @@
     from_nullable_channel,
 )
 from playwright._impl._console_message import ConsoleMessage
+from playwright._impl._credentials import Credentials
 from playwright._impl._debugger import Debugger
 from playwright._impl._dialog import Dialog
 from playwright._impl._disposable import Disposable, DisposableStub
@@ -133,6 +134,7 @@ def __init__(
         self._request: APIRequestContext = from_channel(initializer["requestContext"])
         self._request._timeout_settings = self._timeout_settings
         self._clock = Clock(self)
+        self._credentials = Credentials(self)
         self._channel.on(
             "bindingCall",
             lambda params: self._on_binding(from_channel(params["binding"])),
@@ -741,3 +743,7 @@ def request(self) -> "APIRequestContext":
     @property
     def clock(self) -> Clock:
         return self._clock
+
+    @property
+    def credentials(self) -> Credentials:
+        return self._credentials

playwright/_impl/_browser_type.py

@@ -197,6 +197,7 @@ async def connect_over_cdp(
         headers: Dict[str, str] = None,
         isLocal: bool = None,
         noDefaults: bool = None,
+        artifactsDir: Union[str, Path] = None,
     ) -> Browser:
         params = locals_to_params(locals())
         if params.get("headers"):

playwright/_impl/_connection.py

@@ -94,7 +94,7 @@ def send_no_reply(
         is_internal: bool = False,
         title: str = None,
     ) -> None:
-        # No reply messages are used to e.g. waitForEventInfo(after).
+        # No reply messages are used to e.g. __waitInfo__(after).
         self._connection.wrap_api_call_sync(
             lambda: self._connection._send_message_to_server(
                 self._object,
@@ -413,7 +413,7 @@ def dispatch(self, msg: ParsedMessagePayload) -> None:
             callback = self._callbacks.pop(id)
             if callback.future.cancelled():
                 return
-            # No reply messages are used to e.g. waitForEventInfo(after) which returns exceptions on page close.
+            # No reply messages are used to e.g. __waitInfo__(after) which returns exceptions on page close.
             # To prevent 'Future exception was never retrieved' we just ignore such messages.
             if callback.no_reply:
                 return
@@ -422,6 +422,10 @@ def dispatch(self, msg: ParsedMessagePayload) -> None:
                 parsed_error = parse_error(
                     error["error"], format_call_log(msg.get("log"))  # type: ignore
                 )
+                parsed_error._log = msg.get("log")
+                parsed_error._details = self._replace_guids_with_channels(
+                    msg.get("errorDetails")
+                )
                 parsed_error._stack = "".join(callback.stack_trace.format())
                 callback.future.set_exception(parsed_error)
             else:

playwright/_impl/_credentials.py

@@ -0,0 +1,57 @@
+# Copyright (c) Microsoft Corporation.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+from typing import TYPE_CHECKING, List
+
+from playwright._impl._api_structures import VirtualCredential
+from playwright._impl._helper import locals_to_params
+
+if TYPE_CHECKING:
+    from playwright._impl._browser_context import BrowserContext
+
+
+class Credentials:
+    def __init__(self, browser_context: "BrowserContext") -> None:
+        self._browser_context = browser_context
+        self._loop = browser_context._loop
+        self._dispatcher_fiber = browser_context._dispatcher_fiber
+
+    async def install(self) -> None:
+        await self._browser_context._channel.send("credentialsInstall", None)
+
+    async def create(
+        self,
+        rpId: str,
+        id: str = None,
+        userHandle: str = None,
+        privateKey: str = None,
+        publicKey: str = None,
+    ) -> VirtualCredential:
+        result = await self._browser_context._channel.send_return_as_dict(
+            "credentialsCreate", None, locals_to_params(locals())
+        )
+        return (result or {})["credential"]
+
+    async def delete(self, id: str) -> None:
+        await self._browser_context._channel.send("credentialsDelete", None, {"id": id})
+
+    async def get(
+        self,
+        rpId: str = None,
+        id: str = None,
+    ) -> List[VirtualCredential]:
+        result = await self._browser_context._channel.send_return_as_dict(
+            "credentialsGet", None, locals_to_params(locals())
+        )
+        return (result or {}).get("credentials", [])

playwright/_impl/_errors.py

@@ -16,7 +16,7 @@
 # stable API.
 
 
-from typing import Optional
+from typing import Any, List, Optional
 
 
 def is_target_closed_error(error: Exception) -> bool:
@@ -28,6 +28,8 @@ def __init__(self, message: str) -> None:
         self._message = message
         self._name: Optional[str] = None
         self._stack: Optional[str] = None
+        self._details: Optional[Any] = None
+        self._log: Optional[List[str]] = None
         super().__init__(message)
 
     @property
@@ -57,4 +59,6 @@ def rewrite_error(error: Exception, message: str) -> Exception:
     if isinstance(rewritten_exc, Error) and isinstance(error, Error):
         rewritten_exc._name = error.name
         rewritten_exc._stack = error.stack
+        rewritten_exc._details = error._details
+        rewritten_exc._log = error._log
     return rewritten_exc

playwright/_impl/_fetch.py

@@ -28,6 +28,8 @@
     Headers,
     HttpCredentials,
     ProxySettings,
+    RemoteAddr,
+    SecurityDetails,
     ServerFilePayload,
     StorageState,
 )
@@ -557,6 +559,12 @@ async def json(self) -> Any:
         content = await self.text()
         return json.loads(content)
 
+    async def security_details(self) -> Optional[SecurityDetails]:
+        return self._initializer.get("securityDetails") or None
+
+    async def server_addr(self) -> Optional[RemoteAddr]:
+        return self._initializer.get("serverAddr") or None
+
     async def dispose(self) -> None:
         await self._request._channel.send(
             "disposeAPIResponse",