Alignment fixes

Author: agg23

playwright/_impl/_browser_context.py

@@ -120,6 +120,7 @@ def __init__(
         self._background_pages: Set[Page] = set()
         self._service_workers: Set[Worker] = set()
         self._base_url: Optional[str] = self._options.get("baseURL")
+        self._videos_dir: Optional[str] = self._options.get("recordVideo")
         self._tracing = cast(Tracing, from_channel(initializer["tracing"]))
         self._har_recorders: Dict[str, HarRecordingMetadata] = {}
         self._request: APIRequestContext = from_channel(initializer["requestContext"])
@@ -303,14 +304,6 @@ def pages(self) -> List[Page]:
     def browser(self) -> Optional["Browser"]:
         return self._browser
 
-    @property
-    def base_url(self) -> Optional[str]:
-        return self._base_url
-
-    @property
-    def videos_dir(self) -> Optional[str]:
-        return self._options.get("recordVideo")
-
     async def _initialize_har_from_options(
         self,
         record_har_path: Optional[Union[Path, str]],

playwright/_impl/_frame.py

@@ -586,6 +586,18 @@ async def fill(
         noWaitAfter: bool = None,
         strict: bool = None,
         force: bool = None,
+    ) -> None:
+        await self._fill(**locals())
+
+    async def _fill(
+        self,
+        selector: str,
+        value: str,
+        timeout: float = None,
+        noWaitAfter: bool = None,
+        strict: bool = None,
+        force: bool = None,
+        title: str = None,
     ) -> None:
         await self._channel.send("fill", self._timeout, locals_to_params(locals()))
 

playwright/_impl/_locator.py

@@ -217,7 +217,8 @@ async def clear(
         noWaitAfter: bool = None,
         force: bool = None,
     ) -> None:
-        await self.fill("", timeout=timeout, force=force)
+        params = locals_to_params(locals())
+        await self._frame._fill(self._selector, value="", title="Clear", **params)
 
     def locator(
         self,

playwright/_impl/_page.py

@@ -1181,7 +1181,7 @@ def video(
         # Note: we are creating Video object lazily, because we do not know
         # BrowserContextOptions when constructing the page - it is assigned
         # too late during launchPersistentContext.
-        if not self._browser_context.videos_dir:
+        if not self._browser_context._videos_dir:
             return None
         return self._force_video()
 

tests/async/test_chromium_tracing.py

@@ -51,16 +51,18 @@ async def test_should_run_with_custom_categories_if_provided(
     output_file = tmp_path / "trace.json"
     await browser.start_tracing(
         page=page,
-        screenshots=True,
         path=output_file,
-        categories=["disabled-by-default-v8.cpu_profiler.hires"],
+        categories=["disabled-by-default-cc.debug"],
     )
     await browser.stop_tracing()
     with open(output_file, mode="r") as of:
         trace_json = json.load(of)
+        trace_config = trace_json["metadata"].get("trace-config")
+        trace_events = trace_json["traceEvents"]
         assert (
-            "disabled-by-default-v8.cpu_profiler.hires"
-            in trace_json["metadata"]["trace-config"]
+            trace_config is not None and "disabled-by-default-cc.debug" in trace_config
+        ) or any(
+            event.get("cat") == "disabled-by-default-cc.debug" for event in trace_events
         )