More clearly document strange parsing behavior

Author: agg23

playwright/_impl/_helper.py

@@ -220,12 +220,15 @@ def map_token(original: str, replacement: str) -> str:
     # To ensure the same url matching behavior, do the same.
     split = resolved_url.split("://", maxsplit=1)
     if len(split) == 2:
-        core_url = "http://" + split[1]
+        # URL parser doesn't like strange/unknown schemes, so we replace it for parsing, then put it back
+        parsable_url = "http://" + split[1]
     else:
-        core_url = match
-    parsed = urlparse(core_url, allow_fragments=True)
+        # Given current rules, this should never happen _and_ still be a valid matcher. We require the protocol to be part of the match,
+        # so either the user is using a glob that starts with "*" (and none of this code is running), or the user actually has `something://` in `match`
+        parsable_url = resolved_url
+    parsed = urlparse(parsable_url, allow_fragments=True)
     if len(split) == 2:
-        # urlparse doesn't like stars in the scheme
+        # Replace the scheme that we removed earlier
         parsed = parsed._replace(scheme=split[0])
     if parsed.path == "":
         parsed = parsed._replace(path="/")

tests/async/test_page_route.py

@@ -1102,7 +1102,6 @@ def glob_to_regex(pattern: str) -> re.Pattern:
         "http://mydomain:8080/blah/blah/three-columns/settings.html?id=settings-e3c58efe-02e9-44b0-97ac-dd138100cf7c&blah"
     )
 
-    print(glob_to_regex("\\?").pattern)
     assert glob_to_regex("\\?").pattern == r"^\?$"
     assert glob_to_regex("\\").pattern == r"^\\$"
     assert glob_to_regex("\\\\").pattern == r"^\\$"
@@ -1156,6 +1155,16 @@ def glob_to_regex(pattern: str) -> re.Pattern:
     assert url_matches("http://first.host/", "http://second.host/foo", "**/foo")
     assert url_matches("http://playwright.dev/", "http://localhost/", "*//localhost/")
 
+    # Added for Python implementation
+    assert url_matches(
+        None,
+        "custom://example.com/foo/bar?id=123",
+        "{custom,another}://example.com/foo/bar?id=123",
+    )
+    assert not url_matches(
+        None, "custom://example.com/foo/bar?id=123", "**example.com/foo/bar?id=123"
+    )
+
 
 async def test_should_not_support_question_in_glob_pattern(
     page: Page, playwright: Playwright, server: Server