chore: generate api.json for codegen instead of reading it from the driver#3096
Closed
Skn0tt wants to merge 1 commit into
Closed
chore: generate api.json for codegen instead of reading it from the driver#3096Skn0tt wants to merge 1 commit into
Skn0tt wants to merge 1 commit into
Conversation
…river Python is the only Playwright port that consumes api.json. Until now the codegen read it out of the driver bundle via the hidden `print-api-json` driver CLI. This generates it directly in build_driver.sh (`API_JSON_MODE=1 node generateApiJson.js`) and stages it next to the per-platform bundles as `driver/playwright-<sha>-api.json`, so it survives upstream dropping api.json from the driver bundle. - build_driver.sh: generate and stage api.json; require it on the fast path. - documentation_provider.py: read the staged api.json file directly (drops the subprocess call to `python -m playwright print-api-json`). - update_api.sh: preflight build_driver.sh so the codegen input is staged. - ci.yml: carry the whole driver/ folder (bundles + api.json) in the shared artifact, excluding the playwright-src checkout. - Docs: CLAUDE.md, ROLLING.md, playwright-roll SKILL.md. Follow-up to microsoft#3092 (build driver from source). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
doesn't really give us anything. if we want to improve things, let's mirror what .NET does and parse markdown docs directly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python is the only Playwright port that consumes api.json. Until now the codegen read it out of the driver bundle via the hidden
print-api-jsondriver CLI. This generates it directly in build_driver.sh (API_JSON_MODE=1 node generateApiJson.js) and stages it next to the per-platform bundles asdriver/playwright-<sha>-api.json, so it survives upstream dropping api.json from the driver bundle.python -m playwright print-api-json).Follow-up to #3092 (build driver from source).