chore: build coreBundle (#40074)

Author: pavelfeldman

.gitignore

@@ -39,3 +39,4 @@ test-results
 .eslintcache
 playwright.env
 /firefox/
+.playwright/

eslint.config.mjs

@@ -60,6 +60,7 @@ const ignores = [
   "test-results/",
   "tests/assets/",
   "tests/components/",
+  "tests/config/ghaMarkdownReporter.ts",
   "tests/installation/fixture-scripts/",
   "tests/third_party/",
   "utils/",
@@ -357,17 +358,65 @@ export default [
     },
   },
   {
-    files: ["packages/playwright-core/src/tools/**/*.ts"],
+    files: ["packages/playwright-core/src/**/*.ts"],
+    ignores: [
+      "packages/playwright-core/src/entry/**",
+    ],
     rules: {
       "no-restricted-imports": [
         "error",
         {
           patterns: [{
-            group: ["**/client", "**/client/**"],
-            message: "tools/ must not import from client/",
+            group: ["**/coreBundle"],
+            message: "coreBundle can only be imported from entry/ files. Use direct imports instead.",
           }],
         },
       ],
+    },
+  },
+  {
+    files: ["packages/playwright-core/src/**/*.ts"],
+    ignores: [
+      "packages/playwright-core/src/package.ts",
+      "packages/playwright-core/src/cli/programWithTestStub.ts",
+    ],
+    rules: {
+      "no-restricted-properties": [
+        "error",
+        {
+          object: "process",
+          property: "exit",
+          message:
+            "Please use gracefullyProcessExitDoNotHang function to exit the process.",
+        },
+        { object: "process", property: "stdout" },
+        { object: "process", property: "stderr" },
+        {
+          object: "require",
+          property: "resolve",
+          message: "Use libPath() from package.ts instead of require.resolve.",
+        },
+      ],
+    },
+  },
+  {
+    files: ["packages/playwright-core/src/tools/**/*.ts"],
+    rules: {
+      "no-restricted-imports": [
+        "error",
+        {
+          patterns: [
+            {
+              group: ["**/client", "**/client/**"],
+              message: "tools/ must not import from client/",
+            },
+            {
+              group: ["**/coreBundle"],
+              message: "coreBundle can only be imported from entry/ files. Use direct imports instead.",
+            },
+          ],
+        },
+      ],
       "no-restricted-syntax": [
         "error",
         {

packages/playwright-browser-chromium/install.js

@@ -18,7 +18,7 @@ let install;
 
 try {
   if (!require('playwright-core/lib/coreBundle').serverUtils.isLikelyNpxGlobal())
-    install = require('playwright-core/lib/coreBundle').sever.installBrowsersForNpmInstall;
+    install = require('playwright-core/lib/coreBundle').registry.installBrowsersForNpmInstall;
 } catch (e) {
   // Dev build, don't install browsers by default.
 }

packages/playwright-browser-firefox/install.js

@@ -18,7 +18,7 @@ let install;
 
 try {
   if (!require('playwright-core/lib/coreBundle').serverUtils.isLikelyNpxGlobal())
-    install = require('playwright-core/lib/coreBundle').sever.installBrowsersForNpmInstall;
+    install = require('playwright-core/lib/coreBundle').registry.installBrowsersForNpmInstall;
 } catch (e) {
   // Dev build, don't install browsers by default.
 }

packages/playwright-browser-webkit/install.js

@@ -18,7 +18,7 @@ let install;
 
 try {
   if (!require('playwright-core/lib/coreBundle').serverUtils.isLikelyNpxGlobal())
-    install = require('playwright-core/lib/coreBundle').sever.installBrowsersForNpmInstall;
+    install = require('playwright-core/lib/coreBundle').registry.installBrowsersForNpmInstall;
 } catch (e) {
   // Dev build, don't install browsers by default.
 }

packages/playwright-chromium/install.js

@@ -18,7 +18,7 @@ let install;
 
 try {
   if (!require('playwright-core/lib/coreBundle').serverUtils.isLikelyNpxGlobal())
-    install = require('playwright-core/lib/coreBundle').sever.installBrowsersForNpmInstall;
+    install = require('playwright-core/lib/coreBundle').registry.installBrowsersForNpmInstall;
 } catch (e) {
   // Dev build, don't install browsers by default.
 }

packages/playwright-core/package.json

@@ -27,7 +27,8 @@
     "./lib/mcpBundle": "./lib/mcpBundle.js",
     "./lib/utilsBundle": "./lib/utilsBundle.js",
     "./lib/zipBundle": "./lib/zipBundle.js",
-    "./lib/zodBundle": "./lib/zodBundle.js"
+    "./lib/zodBundle": "./lib/zodBundle.js",
+    "./lib/tools/cli-client/program": "./lib/tools/cli-client/program.js"
   },
   "bin": {
     "playwright-core": "cli.js"

packages/playwright-core/src/DEPS.list

@@ -22,6 +22,7 @@ utilsBundle.ts
 
 [outofprocess.ts]
 client/
+package.ts
 protocol/
 utils/
 utils/isomorphic

packages/playwright-core/src/cli/DEPS.list

@@ -1,6 +1,8 @@
 [*]
 ../inprocess.ts
+../package.ts
 ../server/
+../server/registry/
 ../server/utils/
 ../remote/
 ../utils/

packages/playwright-core/src/cli/browserActions.ts

@@ -22,7 +22,7 @@ import path from 'path';
 
 import { playwright } from '../inprocess';
 import { gracefullyProcessExitDoNotHang, ManualPromise } from '../utils';
-import { dotenv, program } from '../utilsBundle';
+import { debug, dotenv, program } from '../utilsBundle';
 
 import type { Browser } from '../client/browser';
 import type { BrowserContext } from '../client/browserContext';
@@ -267,7 +267,7 @@ async function maybeSetupTestHooks(browser: Browser, closeBrowser: () => Promise
 
   // Make sure we exit abnormally when browser crashes.
   const logs: string[] = [];
-  require('playwright-core/lib/utilsBundle').debug.log = (...args: any[]) => {
+  debug.log = (...args: any[]) => {
     const line = require('util').format(...args) + '\n';
     logs.push(line);
     // eslint-disable-next-line no-restricted-properties