Skip to content

fix(trace-viewer): add keyboard navigation to NetworkFilters component#41284

Merged
dgozman merged 1 commit into
microsoft:mainfrom
triemerge:fix/network-filters-keyboard-nav-v2
Jun 17, 2026
Merged

fix(trace-viewer): add keyboard navigation to NetworkFilters component#41284
dgozman merged 1 commit into
microsoft:mainfrom
triemerge:fix/network-filters-keyboard-nav-v2

Conversation

@triemerge

@triemerge triemerge commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Rationale

Re-land of #41177 (see #41280 (comment)).

Fixes #41175

@dgozman dgozman requested a review from yury-s June 15, 2026 14:46
@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

2 failed
❌ [chrome] › mcp/annotate.spec.ts:399 › should cancel browser_annotate when the MCP client disconnects @mcp-windows-latest-chrome
❌ [chrome] › mcp/annotate.spec.ts:428 › should switch screencast to -s session on show --annotate @mcp-windows-latest-chrome

7326 passed, 1122 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

5 flaky ⚠️ [chromium-library] › library/video.spec.ts:476 › screencast › should capture static page in persistent context @smoke `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-page] › page/workers.spec.ts:190 › should attribute network activity for worker inside iframe to the iframe `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/popup.spec.ts:260 › should not throw when click closes popup `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:224 › cli codegen › should generate frame locators (4) `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-emulate-media.spec.ts:144 › should keep reduced motion and color emulation after reload `@firefox-ubuntu-22.04-node20`

39556 passed, 743 skipped


Merge workflow run.

@dgozman

dgozman commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

@triemerge Thank you for the PR, merging in.

@dgozman dgozman merged commit 3d8f1e9 into microsoft:main Jun 17, 2026
45 of 46 checks passed
@triemerge triemerge deleted the fix/network-filters-keyboard-nav-v2 branch June 17, 2026 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Missing keyboard navigation in NetworkFilters component (trace viewer)

2 participants