feat(webkit): match Safari for device orientation, motion and push#41660
Open
yury-s wants to merge 3 commits into
Open
feat(webkit): match Safari for device orientation, motion and push#41660yury-s wants to merge 3 commits into
yury-s wants to merge 3 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dcrousso
approved these changes
Jul 7, 2026
yury-s
force-pushed
the
deviceorientation-push-api
branch
from
9156ff7 to
6004ebb
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Stop hiding DeviceMotionEvent/DeviceOrientationEvent and the window on-handlers on desktop WebKit (drop the forced DeviceOrientationEventEnabled override and the bootstrap deletions), and enable Push API on desktop so window.PushManager matches real Safari. Update Modernizr expectations and remove the corresponding per-feature overrides from the spec.
Shipping Safari exposes font-display as a settable CSS property, but open-source WebKit keeps it a @font-face descriptor only, so element.style.fontDisplay is undefined and Modernizr reports it false. Keep the JSON snapshot at the real Safari value and override in the spec.
Reflect the Safari version the snapshots were captured from.
yury-s
force-pushed
the
deviceorientation-push-api
branch
from
6004ebb to
39f5ac4
Compare
Contributor
Test results for "tests 1"7 flaky49500 passed, 1162 skipped Merge workflow run. |
Contributor
Test results for "MCP"1 failed 7714 passed, 1242 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DeviceMotionEvent/DeviceOrientationEventand theondevicemotion/ondeviceorientationwindow handlers on desktop WebKit, matching Safari (drop the forcedDeviceOrientationEventEnabledoverride and the bootstrap deletions).window.PushManageris exposed like Safari, via a newPushAPIEnabledinspector setting.safari-18).fontdisplaystays overridden because open-source WebKit exposesfont-displayonly as a@font-facedescriptor, unlike shipping Safari.Requires the matching WebKit change: microsoft/playwright-browsers#2400