chore(test runner): abort operations when tests end#41751
Closed
Skn0tt wants to merge 3 commits into
Closed
Conversation
Use a per-test default abort signal for operations on test-owned contexts while leaving manually managed contexts alone. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c410729d-7f68-4448-8ec3-6ce61ce68388
Use the transmitted abort reason as the server AbortError message so reporter operation errors remain useful. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c410729d-7f68-4448-8ec3-6ce61ce68388
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Skn0tt
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Let dependent fixtures drain in-flight Playwright work before aborting remaining operations. Keep the controller local to each context fixture and preserve the existing unhandled rejection behaviour. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c410729d-7f68-4448-8ec3-6ce61ce68388
Contributor
Test results for "tests 1"2 failed 13 flaky49533 passed, 1161 skipped Merge workflow run. |
Contributor
Test results for "MCP"7760 passed, 1249 skipped Merge workflow run. |
Member
Author
|
good experiment! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR gives test-owned browser contexts a per-test default
AbortSignaland aborts it before fixture teardown. This ends in-flight operations without using context closure as the cancellation mechanism, while manually managed contexts can still span test boundaries.Abort errors keep their generic message and exact cause; the test-end reason remains in call logs.