fix(firefox): network instrumentation misses WebSocket handshakes in Worker#41759
Merged
Conversation
yury-s
approved these changes
Jul 13, 2026
yury-s
left a comment
yury-s
left a comment
Member
There was a problem hiding this comment.
Let's add a TODO in the code somewhere that says when the code should be removed.
| } | ||
|
|
||
| ws.requestSent(headers); | ||
| if (headers) |
Member
There was a problem hiding this comment.
let's wrap bot request params into requestData to make it clear tat there is no request when it's missing? Otherwise it's not clear why we are not reporting request if the headers are missing
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…n `Worker` this is being fixed upstream <https://phabricator.services.mozilla.com/D310690> temporarily working around it for now as only HAR uses the request/response info (e.g. headers, status, etc.)
Contributor
Test results for "MCP"7760 passed, 1249 skipped Merge workflow run. |
Contributor
Test results for "tests 1"6 flaky49559 passed, 1168 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is being fixed upstream https://phabricator.services.mozilla.com/D310690
temporarily working around it for now as only HAR uses the request/response info (e.g. headers, status, etc.)
fixes #41742