fix(browsercontext): clean up extendInjectedScript event listeners on context close#41767
Open
rahulrao85 wants to merge 1 commit into
Open
fix(browsercontext): clean up extendInjectedScript event listeners on context close#41767rahulrao85 wants to merge 1 commit into
rahulrao85 wants to merge 1 commit into
Conversation
… context close The extendInjectedScript method registered event listeners via page.on() and this.on() without ever removing them. Over the lifetime of a browser context, these listeners accumulate, causing a memory leak. Fixes: microsoft#41764
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
\BrowserContext.extendInjectedScript()\ registers event listeners via \page.on()\ and \ his.on()\ but never removes them. This causes a memory leak that grows with each call and each new page.
Changes
Fixes: #41764