fix(proxy): allow TLS upgrade retry on transient failure and handle async error rejection#41768
Open
rahulrao85 wants to merge 1 commit into
Open
fix(proxy): allow TLS upgrade retry on transient failure and handle async error rejection#41768rahulrao85 wants to merge 1 commit into
rahulrao85 wants to merge 1 commit into
Conversation
…sync error rejection Two fixes in socksClientCertificatesInterceptor.ts: 1. _upgradeToTLSIfNeeded: clear the cached promise on rejection so subsequent calls can retry instead of permanently failing 2. _establishTlsTunnel async error handler: wrap in try/catch to prevent unhandled promise rejection Fixes: microsoft#41765
|
@rahulrao85 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes in \socksClientCertificatesInterceptor.ts:
Cached rejected promise: _upgradeToTLSIfNeeded\ used ??=\ to cache the TLS upgrade promise. If TLS upgrade failed once, the rejected promise was permanently cached - all subsequent calls also failed. Now the cache is cleared on rejection so retry works.
Unhandled rejection in async error handler: The \serverDecrypted.once('error', async ...)\ handler at line 211 was an async function whose returned promise was never caught. If _upgradeToTLSIfNeeded\ threw, it produced an unhandled rejection. Now wrapped in try/catch.
Fixes: #41765