fix(fetch): use case-insensitive host header lookup on redirect#41769
Open
rahulrao85 wants to merge 1 commit into
Open
fix(fetch): use case-insensitive host header lookup on redirect#41769rahulrao85 wants to merge 1 commit into
rahulrao85 wants to merge 1 commit into
Conversation
The redirect host header update used headers['host'] (lowercase only), but setHeader() preserves the original casing of header names. If extraHTTPHeaders set 'Host' (capital H), the redirect's host update was silently skipped. Now uses case-insensitive lookup like setHeader, getHeader, and removeHeader in the same file. Fixes: microsoft#41766
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The redirect host header update used \headers['host']\ (lowercase only), but \setHeader()\ preserves the original casing of header names. If \extraHTTPHeaders\ set 'Host'\ (capital H), the host was never updated on redirect, causing the request to be sent with the original origin's Host header.
Now uses case-insensitive lookup (\Object.keys().find()), consistent with \setHeader, \getHeader, and
emoveHeader\ in the same file.
Fixes: #41766