Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 3.4.4.0
### Fixes
* Fixed event rendering issue

## 3.4.3.0
### Fixes
* Fixed event description position
Expand Down
24 changes: 3 additions & 21 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@microsoft/powerbi-visuals-pulsechart",
"description": "Pulse chart shows a line chart annotated with key events. Each events can be selected to filter and cross highlight other visuals to reveal insights or help tell a story. Pulse chart supports animation so you can load your report and watch it play through key events, without user interaction. This visualization is perfect for story telling with data, especially the Power BI publish to web feature. Use it anywhere you need to draw attention to events that shaped a trend.",
"version": "3.4.3.0",
"version": "3.4.4.0",
"private": true,
"author": {
"name": "Microsoft",
Expand Down
4 changes: 2 additions & 2 deletions pbiviz.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"visual": {
"name": "PulseChart",
"displayName": "Pulse Chart 3.4.3.0",
"displayName": "Pulse Chart 3.4.4.0",
"guid": "PulseChart1459209850231",
"visualClassName": "Visual",
"version": "3.4.3.0",
"version": "3.4.4.0",
"description": "Pulse chart shows a line chart annotated with key events. Each events can be selected to filter and cross highlight other visuals to reveal insights or help tell a story. Pulse chart supports animation so you can load your report and watch it play through key events, without user interaction. This visualization is perfect for story telling with data, especially the Power BI publish to web feature. Use it anywhere you need to draw attention to events that shaped a trend.",
"supportUrl": "https://community.powerbi.com",
"gitHubUrl": "https://github.com/Microsoft/powerbi-visuals-pulsechart"
Expand Down
3 changes: 3 additions & 0 deletions src/visual.ts
Original file line number Diff line number Diff line change
Expand Up @@ -594,6 +594,7 @@ export class Visual implements IVisual {
this.host.eventService.renderingStarted(options);
try {
if (!options?.dataViews?.[0]) {
this.host.eventService.renderingFinished(options);
return;
}

Expand All @@ -615,6 +616,7 @@ export class Visual implements IVisual {

if (!this.validateData(this.data)) {
this.clearAll(true);
this.host.eventService.renderingFinished(options);
return;
}

Expand All @@ -628,6 +630,7 @@ export class Visual implements IVisual {

if (this.data.xScale.ticks(undefined).length < 2) {
this.clearAll(true);
this.host.eventService.renderingFinished(options);
return;
}

Expand Down
Loading