Skip to content

chore: modernize lint and tsconfig setup #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zhannurkhan04 wants to merge 1 commit into
base: main
Choose a base branch
from
+856 −1,631
Open

chore: modernize lint and tsconfig setup #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions .eslintignore
View file
Open in desktop

This file was deleted.

20 changes: 0 additions & 20 deletions .eslintrc.js
View file
Open in desktop

This file was deleted.

11 changes: 11 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,15 @@

## 7.0.0

### Changed
* Migrated ESLint config to flat-config ESM `eslint.config.mjs`.
* Removed legacy `.eslintrc.js` and `.eslintignore` in favor of flat-config equivalents.
Copy link
Copy Markdown
Contributor

@Demonkratiy Demonkratiy Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bullet doesn't match the actual tsconfig changes

Two inaccuracies vs. the tsconfig.json shipped in this PR:

  1. ignoreDeprecations is not set anywhere in the new tsconfig.json. Either drop it from this bullet or add it to the config (TS 6 reports several deprecations from the previous setup — ignoreDeprecations: "6.0" is what this line implies).
  2. strict: true is effectively disabled. Right next to it the PR sets strictNullChecks: false, strictPropertyInitialization: false, noImplicitAny: false, which turns off the three biggest strict-mode checks. Advertising "strict" here is misleading — consumers won't get strict-mode guarantees. Either remove the claim or actually enable the sub-flags.

* Updated TypeScript config for TS6 compatibility, including `ignoreDeprecations`, explicit `rootDir`, `strict: true`, and a modern `lib` target.
* Documented why `skipLibCheck` is required for Power BI API declaration compatibility.

### Infrastructure
* Lint config now uses ESLint 10 flat config with TypeScript ESLint 8.

## 6.2.2
* Added missing `disabled` property to `FontPicker`

Expand Down
26 changes: 26 additions & 0 deletions eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
import powerbiVisuals from "eslint-plugin-powerbi-visuals";

export default [
{
ignores: [
"node_modules/**",
"dist/**",
"coverage/**",
"test/**",
"karma.conf.ts",
"webpack.config.js",
"lib/**",
".tmp/**",
],
Comment on lines +5 to +14
Copy link
Copy Markdown
Contributor

@Demonkratiy Demonkratiy Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignores list contains paths that don't exist in this repository

The list looks copy-pasted from a Power BI visual template. This repo is a utility library with only src/, lib/, and node_modules/ as code-bearing directories — dist/, coverage/, test/, karma.conf.ts, webpack.config.js, .tmp/ are not present.

Suggested trim:

ignores: [
    "node_modules/**",
    "lib/**",
],

If the boilerplate entries are kept intentionally (e.g. anticipating a future test runner), a short comment would help future maintainers.

},
{
...powerbiVisuals.configs.recommended,
languageOptions: {
...powerbiVisuals.configs.recommended.languageOptions,
parserOptions: {
project: "tsconfig.json",
tsconfigRootDir: import.meta.dirname,
},
},
},
];
Loading
Loading