fix(azure): update DatastoreType import#4181
Open
fengjikui wants to merge 1 commit into
Open
Conversation
Author
|
@microsoft-github-policy-service agree |
|
Hi, thank you for your interest in helping to improve the prompt flow experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. |
Author
|
Still active from my side. I rechecked that the PR is mergeable and the visible checks are green; happy to adjust if the DatastoreType compatibility import should follow a different preferred path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DatastoreTypefrom the removedazure.ai.ml._restclient.v2022_10_01namespace.v2022_10_01_previewnamespace and falls back to the old namespace for older SDK layouts.Fixes #4176.
Verification
uv run --with azure-ai-ml==1.33.0 python - <<'PY' ...verified the compat module resolvesAzureBlob,AzureDataLakeGen2, andAzureFileunderazure-ai-ml==1.33.0.python3 -m py_compile src/promptflow-azure/promptflow/azure/_utils/_datastore_type.py src/promptflow-azure/promptflow/azure/operations/_artifact_utilities.py src/promptflow-azure/promptflow/azure/_storage/blob/client.py src/promptflow-azure/tests/sdk_cli_azure_test/unittests/test_blob_client.pyuvx black --check src/promptflow-azure/promptflow/azure/_utils/_datastore_type.py src/promptflow-azure/promptflow/azure/operations/_artifact_utilities.py src/promptflow-azure/promptflow/azure/_storage/blob/client.py src/promptflow-azure/tests/sdk_cli_azure_test/unittests/test_blob_client.pygit diff --checkI also tried the repository's
poetry install --with ci,testfromsrc/promptflow-azure, but dependency resolution did not complete locally after several minutes, so I kept local validation focused on the import compatibility path.