collapse error pane by default (#11199)

Author: riknoll

localtypings/pxteditor.d.ts

@@ -820,7 +820,7 @@ declare namespace pxt.editor {
         simSerialActive?: boolean;
         deviceSerialActive?: boolean;
         errorListState?: ErrorListState;
-        errorListCollapsedByUser?: boolean;
+        errorListCollapsed?: boolean;
         screenshoting?: boolean;
         extensionsVisible?: boolean;
         isMultiplayerGame?: boolean; // Arcade: Does the current project contain multiplayer blocks?

webapp/src/app.tsx

@@ -205,7 +205,8 @@ export class ProjectView
             isMultiplayerGame: false,
             activeTourConfig: undefined,
             mute: pxt.editor.MuteState.Unmuted,
-            feedback: {showing: false, kind: "generic"} // state that tracks if the feedback modal is showing and what kind
+            feedback: {showing: false, kind: "generic"}, // state that tracks if the feedback modal is showing and what kind
+            errorListCollapsed: true // error pane is collapsed by default
         };
         if (!this.settings.editorFontSize) this.settings.editorFontSize = /mobile/i.test(navigator.userAgent) ? 15 : 19;
         if (!this.settings.fileHistory) this.settings.fileHistory = [];

webapp/src/blocks.tsx

@@ -1092,7 +1092,7 @@ export class Editor extends toolboxeditor.ToolboxEditor {
                     <ErrorList
                         errors={this.errors}
                         onSizeChange={this.onErrorListResize}
-                        collapsedByUser={this.parent.state.errorListCollapsedByUser}
+                        collapsedByUser={this.parent.state.errorListCollapsed}
                         onUserCollapse={this.setErrorListCollapsePreference}
                         getErrorHelp={this.getErrorHelp}
                         showLoginDialog={this.parent.showLoginDialog}
@@ -1109,7 +1109,7 @@ export class Editor extends toolboxeditor.ToolboxEditor {
 
     protected setErrorListCollapsePreference = (collapsed: boolean) => {
         this.parent.setState({
-            errorListCollapsedByUser: collapsed
+            errorListCollapsed: collapsed
         });
     }
 

webapp/src/monaco.tsx

@@ -664,7 +664,7 @@ export class Editor extends toolboxeditor.ToolboxEditor {
                     {showErrorList && (
                         <ErrorList
                             onSizeChange={this.setErrorListState}
-                            collapsedByUser={this.parent.state.errorListCollapsedByUser}
+                            collapsedByUser={this.parent.state.errorListCollapsed}
                             onUserCollapse={this.setErrorListCollapsePreference}
                             errors={this.errors}
                             startDebugger={this.startDebugger}
@@ -963,7 +963,7 @@ export class Editor extends toolboxeditor.ToolboxEditor {
 
     protected setErrorListCollapsePreference = (collapsed: boolean) => {
         this.parent.setState({
-            errorListCollapsedByUser: collapsed
+            errorListCollapsed: collapsed
         });
     }