Skip to content

Commit e823aa9

Browse files
authored
disable architecture detection for offline app page (#11183)
* remove recommended for mac offline since it's not accurately detecting * don't recommend at all, doesn't seem consistent anymore on my arm device either
1 parent d59d9da commit e823aa9

1 file changed

Lines changed: 8 additions & 10 deletions

File tree

docfiles/offline-app-head.html

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -530,17 +530,15 @@
530530
let recommendedButton = null;
531531

532532
if (isMac) {
533-
if (isAppleSilicon) {
534-
recommendedButton = $("#download-macarm64");
535-
} else {
536-
recommendedButton = $("#download-mac64");
537-
}
533+
// Do not recommend a Mac binary because architecture detection is unreliable across browsers
534+
recommendedButton = null;
538535
} else if (isWindows) {
539-
if (false && isWindowsARM) {
540-
recommendedButton = $("#download-winarm64");
541-
} else {
542-
recommendedButton = $("#download-win64");
543-
}
536+
// if (false && isWindowsARM) {
537+
// recommendedButton = $("#download-winarm64");
538+
// } else {
539+
// recommendedButton = $("#download-win64");
540+
// }
541+
recommendedButton = null;
544542
}
545543

546544
// Mark the recommended download

0 commit comments

Comments
 (0)