remove hex info packaging (#11425)

* save using full 32 bits instead of seeing out upper 16

* cull the hex info, only keep the packaged extension content

* Revert "save using full 32 bits instead of seeing out upper 16"

This reverts commit 58a3866.

Author: jwunderl

pxtlib/cpp.ts

@@ -1526,11 +1526,6 @@ namespace pxt.hexloader {
         return JSON.stringify(cachedMeta);
     }
 
-    export function storeHexInfoCacheEntryAsync(host: Host, sha: string, cachedHexInfo: string) {
-        if (!sha || !cachedHexInfo) return Promise.resolve();
-        return storeWithLimitAsync(host, "hex-keys", "hex-" + sha, cachedHexInfo);
-    }
-
     export function getHexInfoAsync(host: Host, extInfo: pxtc.ExtensionInfo, cloudModule?: any): Promise<pxtc.HexInfo> {
         if (!extInfo.sha)
             return Promise.resolve<any>(null)

pxtlib/main.ts

@@ -542,7 +542,6 @@ namespace pxt {
     export const TUTORIAL_INFO_FILE = "tutorial-info-cache.json";
     export const TUTORIAL_CUSTOM_TS = "tutorial.custom.ts";
     export const PACKAGED_EXTENSIONS = "_packaged-extensions.json";
-    export const PACKAGED_EXT_INFO = "_packaged-ext-info.json";
     export const BREAKPOINT_TABLET = 991; // TODO (shakao) revisit when tutorial stuff is more settled
     export const PALETTES_FILE = "_palettes.json";
     export const HISTORY_FILE = "_history";

pxtlib/package.ts

@@ -1282,9 +1282,6 @@ namespace pxt {
 
             if (!noFileEmbed) {
                 const files = await this.filesToBePublishedAsync(true, !appTarget.compile.useUF2)
-                const packagedExtInfo = this.packagedExtensionHexInfo(opts);
-                if (Object.keys(packagedExtInfo).length)
-                    files[pxt.PACKAGED_EXT_INFO] = JSON.stringify(packagedExtInfo);
                 const headerString = JSON.stringify({
                     name: this.config.name,
                     comment: this.config.description,
@@ -1422,21 +1419,6 @@ namespace pxt {
             return packaged;
         }
 
-        private packagedExtensionHexInfo(opts: pxtc.CompileOptions): pxt.Map<string> {
-            const packaged: pxt.Map<string> = {};
-            const targets = [opts, ...(opts.otherMultiVariants || [])];
-
-            for (const target of targets) {
-                const extInfo = target.extinfo;
-                if (!extInfo?.sha || !extInfo.hexinfo?.hex) continue;
-
-                const serialized = pxt.hexloader.stringifyHexInfoForCache(extInfo.hexinfo);
-                if (serialized) packaged[extInfo.sha] = serialized;
-            }
-
-            return packaged;
-        }
-
         saveToJsonAsync(): Promise<pxt.cpp.HexFile> {
             return this.filesToBePublishedAsync(true)
                 .then(files => {

webapp/src/workspace.ts

@@ -775,13 +775,7 @@ export async function installAsync(h0: InstallHeader, text: ScriptText, dontOver
         packagedExtensionFiles = pxt.Util.jsonTryParse(text[pxt.PACKAGED_EXTENSIONS]);
         delete text[pxt.PACKAGED_EXTENSIONS];
     }
-    let packagedExtInfo: pxt.Map<string>;
-    if (text[pxt.PACKAGED_EXT_INFO]) {
-        packagedExtInfo = pxt.Util.jsonTryParse(text[pxt.PACKAGED_EXT_INFO]);
-        delete text[pxt.PACKAGED_EXT_INFO];
-    }
 
-    await cachePackagedExtInfoAsync(packagedExtInfo);
     await cachePackagedScriptExtensionsAsync(packagedExtensionFiles);
     await pxt.github.cacheProjectDependenciesAsync(cfg, packagedExtensionFiles)
     await importAsync(h, text);
@@ -815,34 +809,6 @@ async function cachePackagedScriptExtensionsAsync(packagedExtensionFiles?: pxt.M
     }));
 }
 
-async function cachePackagedExtInfoAsync(packagedExtInfo?: pxt.Map<string>) {
-    if (!packagedExtInfo) return;
-
-    const hostCache = await indexedDBWorkspace.getObjectStoreAsync<{ id: string, val: string }>(indexedDBWorkspace.HOSTCACHE_TABLE);
-    const cacheHost = {
-        cacheStoreAsync: async (id: string, val: string) => {
-            await hostCache.setAsync({ id, val });
-        },
-        cacheGetAsync: async (id: string) => {
-            try {
-                return (await hostCache.getAsync(id)).val;
-            }
-            catch (e) {
-                return null;
-            }
-        }
-    } as pxt.Host;
-
-    await Promise.all(Object.keys(packagedExtInfo).map(async sha => {
-        try {
-            await pxt.hexloader.storeHexInfoCacheEntryAsync(cacheHost, sha, packagedExtInfo[sha]);
-        }
-        catch (e) {
-            pxt.log("Unable to cache packaged extension hex info in DB");
-        }
-    }));
-}
-
 export async function renameAsync(h: Header, newName: string): Promise<Header> {
     const text = await getTextAsync(h.id);