[Stable11.3] fix workspace variable deleting bug#10916
Merged
riknoll merged 1 commit intoOct 23, 2025
Merged
Conversation
jwunderl
approved these changes
Oct 23, 2025
This was referenced Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is NOT a cherry pick!
this is a fix for microsoft/pxt-arcade#6983
this does not need to be fixed in master, because i re-implemented how the flyout works for keyboard nav. however, we can't take those changes without taking all the blockly changes, so this is a targeted fix for this issue in arcade's stable branch. microbit and minecraft are not affected
the bug here was that for some reason disposing of the cached flyouts was also disposing the variable map of the main workspace. this fix removes that logic, which technically opens us up to a memory leak (though i think it's very unlikely to be a problem) but stops your project from being permanently ruined so i'd say that's a net win.
i'd like to hotfix this and #10908 ASAP. the other PR will help restore projects that have previously experienced this bug