Fix iframe reloadEditor no-op once fragment is on the URL#11184
Merged
Conversation
This only applies in the iframe / no-cookie case as otherwise reload was already called. After one reloadEditor adds #editor, navigating to the same URL via location.assign(location.toString) doesn't actually reload as it's counted as a fragment navigation only. So it worked the first time only (e.g. when toggling keyboard controls you can only toggle once). This isn't an issue for micro:bit apps embedding MakeCode as they're same-site and go down the path that already reloaded, but confused me a lot when testing the iframe embedding in a non-same-site context.
riknoll
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This only applies in the iframe / no-cookie case as otherwise reload was already called.
After one reloadEditor adds #editor, navigating to the same URL via location.assign(location.toString) doesn't actually reload as it's counted as a fragment navigation only. So it worked the first time only (e.g. when toggling keyboard controls you can only toggle once).
This isn't an issue for micro:bit apps embedding MakeCode as they're same-site and go down the path that already reloaded, but confused me a lot when testing the iframe embedding in a non-same-site context.
Convincing yourself: