Skip to content

Fix iframe reloadEditor no-op once fragment is on the URL #11184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
riknoll merged 2 commits into from
Mar 11, 2026
Merged

Fix iframe reloadEditor no-op once fragment is on the URL #11184

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17933aa
Fix iframe reloadEditor no-op once fragment is on the URL
microbit-matt-hillsdon Mar 9, 2026
a457cce
Merge branch 'master' into reload-fix
riknoll Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions webapp/src/app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2981,10 +2981,11 @@ export class ProjectView
if (hc) params.set("hc", "1");
else params.delete("hc");
}
// Need to add the URL parameters to the URL for the reload.
// Assigning to search will navigate on the first call but reload() needed
// for subsequent calls if there's a fragment (e.g. #editor).
location.search = params.toString();
// .reload refreshes without hitting server so it loses the params,
// so have to navigate directly
location.assign(location.toString());
location.reload();
} else {
location.reload();
}
Expand Down
Loading